Constant NullReferenceException with Reduced Rates active

[joelspadin]

When the company action Reduced Rates is active, I get repeated null reference exceptions in ActorEntityHelper.cs line 201. statusEntry.StatusID is 0, and StatusEffectHelper.StatusInfo() returns null.

[Icehunter]

Is it only on reduced rates?

I have all the ID's setup and that one is here:

https://github.com/Icehunter/ffxivapp-common/blob/master/FFXIVAPP.Common/Helpers/StatusEffectHelper.cs#L4413

If the ID is wrong and doesn't exist though it should return a "???" as the info.

https://github.com/Icehunter/ffxivapp-common/blob/master/FFXIVAPP.Common/Helpers/StatusEffectHelper.cs#L64

What's the status ID when it hits here:?
https://github.com/Icehunter/ffxivapp/blob/master/FFXIVAPP.Client/Helpers/ActorEntityHelper.cs#L200

[joelspadin]

Reduced Rates was the only buff/debuff up at the time, but after looking at it again, I don't think it's related to that specific buff.

The status ID was 0. StatusEffects did contain a key "0" which apparently had a value of null, as StatusEffects.ContainsKey(id) returned true. When I inspected StatusEffects with the debugger, it had a two or three keys with values of null at the beginning. I restarted the program, and StatusEffects no longer has those keys, so I am not sure what happened. It looks like StatusInfo() is called repeatedly with ID 0, and StatusEffects somehow got modified or corrupted.

[Icehunter]

Code-wise though it shouldn't do that; so it's a mystery to me right now. There's a lock on the array and zero never exists so it should always return a default unknown status.

I'll have to look at that more.

[joelspadin]

I'll let you know exactly what the contents of StatusEffects look like if I see it happen again.