Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application.

[zoripong]

Hi.

Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function.

I’m using logout hook now, but it didn’t clean up inside useEffect, causing memory leak. (ref)

In addition, google scripts are being added every time a component is re-rendered.

[zoripong]

Have you mind if I fix it?

[anthonyjgrove]

A PR would be great

[zoripong]

I fixed it in #312.

[iammrsea]

Still getting memory leaks warning

[Molly6943]

memory leaks warning is still there

[thebrucecgit]

I'm still getting the warning

[lejsue]

me too, but it's not happened every time. I downgrade to 5.1.2 now and see if this warning is still there.

[lejsue]

I checked the code and found it seems the setLoaded(true) in line 89 and 97 in use-google-login.js.
maybe can add isMountedRef by useRef like this page: https://www.debuggr.io/react-update-unmounted-component/
and check if isMountedRef.current is true before calling setLoaded(true)
but, it seems this method is anti-pattern.

[zoripong]

I still had a problem.
But I didn't think it was just this library because it was mixed with other problems in the production I was making.

I checked the #311 (comment). I think it's better to be fixed.
I'll reopen the issue.

[kowalus23]

Still the same? any chance for the fix? i mean, it's not a big deal, but good lib, and would be greate to have it perfectly fit in our apps

[jonas060831]

yup still there...