iss #1219 #1223 #1224 reference ignored in name from address (#1222)

* #1219 added code to check reference mod bit in ClassicCheckPointAgent::getCompositeSubReference, use reference width instead of size.

* #1219 refactor getCompositeSubReference for readability

* #1219 and #1223 add reference width to mod bits in ICG

* check for mod bits in TRICK_STRUCTURED section, refactor function

* #1219 adding MM_ref_name_from_address tests

* #1224 fix logic for offset into arrayed struct

closes #1219 closes #1223 closes #1224 

Co-authored-by: Fennell, Scott P 263712616 <scott.p.fennell@nasa.gov>

Author: spfennell

include/trick/attributes.h

@@ -98,6 +98,12 @@ typedef struct ATTRIBUTES_tag {
                                 bit 0 = c++ reference var
                                 bit 1 = c++ static var
                                 bit 2 = "--" units
+                                bit 3-8:
+                                if c++ reference bit is set, width of reference attribute.
+                                else not set.
+                                    Why: because `size` is the size of the type, not the reference
+                                    reference is the size of a pointer because of compiler implementations, but
+                                    is not enforced by C++ standard (could change).
                                 bit 31 = deprecated var */
 
     long offset;        /**< -- Offset in bytes of this parameter from beginning of data structure */

trick_source/codegen/Interface_Code_Gen/PrintFileContents10.cpp

@@ -76,7 +76,8 @@ void PrintFileContents10::print_field_attr(std::ostream & ostream ,  FieldDescri
         ostream << ", sizeof(" << fdes.getTypeName() << ")" ;
     }
     ostream << ", 0, 0, Language_CPP" ; // range_min, range_max, language
-    ostream << ", " << fdes.isReference() + (fdes.isStatic() << 1) + (fdes.isDashDashUnits() << 2) << "," << std::endl ; // mods
+    // mods (see attributes.h for descriptions)
+    ostream << ", " << fdes.isReference() + (fdes.isStatic() << 1) + (fdes.isDashDashUnits() << 2) + (fdes.isReference() ? (((fdes.getFieldWidth() / 8) & 0x3F) << 3) : 0) << "," << std::endl ; // mods
     if ( fdes.isBitField() ) {
         // For bitfields we need the offset to start on 4 byte boundaries because that is what our
         // insert and extract bitfield routines work with.