Stopping item_slot from calling _drop_data from _inventory_grid_stacked_transfer if the item is not to be unequipped

[HarbourHeading]

Hi, I'm using inventory_grid_stacked_transfer.gd for my inventory and ctrl_item_slot.gd for my equipment/item slots. Tested this on the current stable gloot version and saw the same issue however. I create a drop_data_instance so items are dropped on the ground like so in inventory_grid_stacked_transfer.gd:

func _drop_data(_at_position: Vector2, data: Variant) -> void:	
	%CtrlInventoryGridLeft.inventory.remove_item(data)
	%CtrlInventoryGridRight.inventory.remove_item(data)
	
	var item := (data as InventoryItem)
	
	var player: Node = get_owner()
	
	var dropped_item_instance: Node = load("res://utils/inventory/dropped_item.tscn").instantiate()
	dropped_item_instance.item = item
	dropped_item_instance.position = player.position
	get_tree().get_current_scene().add_child(dropped_item_instance)

However, ctrl_item_slot.gd also calls it when dragging the item from the item slot outside the inventory, even though the item in the item slot is not unequipped. Is there an intended way to circumvent this? I am not 100% sure where the slot calls _drop_data from, the control flow was not the easiest to follow I'm afraid.

Any help at all would be greatly appreciated!

[peter-kish]

Not sure I fully understand the issue here.

dragging the item from the item slot outside the inventory, even though the item in the item slot is not unequipped

So, is the item equipped in the slot or not? If not then how is it being dragged from the item slot?
Maybe putting together a Minimal reproducible example would demonstrate the issue better?

[HarbourHeading]

Well, rereading this, its a pretty good example of the 3 am brain 🤦 The issue is that I have duplicated ItemSlot and CtrlItemSlot into 2 slots, bookSlot and ArmorSlot. I am using a property in the protoset slot_type to then check if they can enter the provided slot if item.get_property("slot_type", "item") != _KEY_ITEM: return false in item_slot.gd:84, exporting _KEY_ITEM. Problem is, my current solution to check which slot should be cleared when _drop_data calls is.. ugly. I'm wondering if there is an intended way to do it? Currently my _drop_data is:

func _drop_data(_at_position: Vector2, data: Variant) -> void:
	%CtrlInventoryGridLeft.inventory.remove_item(data)
	%CtrlInventoryGridRight.inventory.remove_item(data)
	if (data as InventoryItem).get_property("slot_type", "item") == "book":
		%BookSlot.clear()
	if (data as InventoryItem).get_property("slot_type", "item") == "armor":
		%ArmorSlot.clear()
		
	(dropping item omitted...)

which works fine as far as functionality is concerned. Below is an MRE from the latest Gloot version, tested on 4.5.dev1.mono of the exact configuration explained above.
gloot-mre-slots.zip