What is the best way to implement this addon?

[F0xer98]

Hey guys, Im new to this addon, so i'm still struggling with this.

Going straight forward:

I found this addon quite unique and very powerful for what it proposes.
As the title says, what is the best approach for this?

To use the addon only with the .json, to serialize the items, can someone give some hints?

For example, the function: create_and_add_item() it only creates an "inventory_item" and adds it to the node inventory, and how to create in one pass all the .json i have in my project to become an "inventory_item" and avoid having headaches?

in case someone cares, here is my discord for faster comunication:
f0xer99

Thank you for this addon @peter-kish, wish you all the best.

[peter-kish]

To use the addon only with the .json, to serialize the items, can someone give some hints?

I assume you're talking about the .json resource that holds the item prototypes. Those aren't really meant to define the contents of individual inventories, they are just "templates" for items that you want to use in your project.

The general workflow I imagined is something like this:

1. Define some item prototypes inside a .json
2. Create an inventory node
3. Add inventory items that are based on the prototypes defined in step 1.
4. If you want to re-use some of the inventories you created, just save them as separate scenes and instantiate them where needed

[F0xer98]

Ok, I got the idea that .json is used to define properties to any item, this is fine.
But my main question is:

• What if I want to create a loot system / boss drop system, or even a simple collect system. What would be the best approach with you addon?

I'll be more specific in a problem I'm having your addon, this might clarify some things.

I designed a very simple collect system which consists of 1 box that has a label on top of it that says which kind of item is expected to go to player's inventory.

But when it comes to add an specific amount of items to be passed through signal, only 1 unit of that item is sent to inventory.

This image refers to the amount of items supposed to be sent to inventory

This image refers to the default settings of the previous test item

• So, by thinking of this way, the best approach would to serialize everysingle possible item, or to use them on the go just like I tried to do previously?

If its too difficult to understand what I mean, try to think like minecraft's items. Every single one of them has an ID, they exists in a dictionary (probably hardcoded) and everytime you do something, that item goes to you.

Ty for the reply !

[F0xer98]

I got another question when I was finishing this reply.

Every single InventoryItem that is created in the grid is unique ?
Lets say, in the previous example the coin has amount of 1 and a unique id of lets say: "coin:1" and when adding another coin it will be id "coin:2"

Its this way how it works or am I complicating too much things?

[peter-kish]

Ah, now I think I understand. You can set the default stack size and max. stack size in the item prototype, so that whenever you create an item with that prototype it will have that stack size.

This section of the README.md gives a good example:

{
    // The default stack size and the default maximum stack size is 1:
    "watch": {},
    // A full deck of 52 cards:
    "deck_of_cards": {
        "stack_size": 52,
        "max_stack_size": 52
    },
    // Half a magazine of bullets:
    "pistol_bullets": {
        "stack_size": 12,
        "max_stack_size": 24
    }
}

With these prototypes the default stack size for a "deck_of_cards" will be 52 and can be modified using set_stack_size:

var new_item = inventory.create_and_add_item("deck_of_cards")
print(new_item.get_stack_size()) # Should print 52

new_item.set_stack_size(50)
print(new_item.get_stack_size()) # Should print 50

new_item.set_stack_size(100)
print(new_item.get_stack_size()) # Still 50, can't go above max_stack_size

As for your second question: yes, items are unique as long as they belong to separate stacks. Items in the same stack share all properties. E.g.:

var new_item_stack = inventory.create_and_add_item("deck_of_cards")

# This sets the ID for all 52 cards. There is no way to set a property for only the 1st card in the stack.
new_item_stack.set_property("unique_id", "deck:1")

# But we can set the ID of a different stack
var another_item_stack = inventory.create_and_add_item("deck_of_cards")
another_item_stack.set_property("unique_id", "deck:2")

print(new_item_stack.get_property("unique_id")) # Should print "deck:1"
print(another_item_stack.get_property("unique_id")) # Should print "deck:2"

I hope this answers your questions. Let me know if I still missed something.