Skip to content

Commit c21d1ac

Browse files
authored
Merge pull request #109 from vrdist-john/hotfix/update-booleans
PrintNodeApiRequestor incorrectly casts booleans to strings
2 parents 04cabeb + 63a1883 commit c21d1ac

File tree

2 files changed

+14
-6
lines changed

2 files changed

+14
-6
lines changed

src/Api/PrintNode/PrintNodeApiRequestor.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,12 +72,12 @@ private static function encodeObjects(mixed $objects): mixed
7272
return Util::utf8($objects->id);
7373
}
7474

75-
if ($objects === true) {
76-
return 'true';
75+
if ($objects === 'true') {
76+
return true;
7777
}
7878

79-
if ($objects === false) {
80-
return 'false';
79+
if ($objects === 'false') {
80+
return false;
8181
}
8282

8383
if (is_array($objects)) {

tests/Feature/Api/PrintNode/PrintNodeApiRequestorTest.php

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,19 @@
5959
],
6060
'boolean true' => fn () => [
6161
'value' => true,
62-
'expected' => 'true',
62+
'expected' => true,
63+
],
64+
'string boolean true' => fn () => [
65+
'value' => 'true',
66+
'expected' => true,
6367
],
6468
'boolean false' => fn () => [
6569
'value' => false,
66-
'expected' => 'false',
70+
'expected' => false,
71+
],
72+
'string boolean false' => fn () => [
73+
'value' => 'false',
74+
'expected' => false,
6775
],
6876
]);
6977

0 commit comments

Comments
 (0)