fix(Example): Web example shows a blank split button page

[Feichtmeier]

oh no, now they are invisible in the xample https://ubuntu.github.io/yaru.dart/ :D
I guess it is an exception?

@ashuntu if you would clone this repo and work with this on your computer rather than the fork of you, we could just run this workflow here in pull requests to test it before merging:

Originally posted by @Feichtmeier in #1047

[ashuntu]

Do you know why/how this happens?

[Feichtmeier]

Do you know why/how this happens?

I think since you removed the fixed dimensions the split button now shrinks as far as it could
if you give the rows and tiles width and height everything shows up without exceptions
but I think you need to re-add fixed height/width to the buttons : /

you can start the web example with just using chrome as the target
but the buttons should look the same on linux imo

[ashuntu]

Ah, it's because the Row in the split button was changed to allow the children to expand on the cross axis, and if there isn't a well-defined height then it has issues. Weird that this never came up in my testing of this locally but now it does.

I still don't think a hard-coded size should be the fix here, I'll look into it.

Edit: intrinsic height for the row seems to work fine

[Feichtmeier]

Imo ideal would be if it would behave like material buttons they also don't change in size

[ashuntu]

Imo ideal would be if it would behave like material buttons they also don't change in size

How do you mean? Before this change, the dropdown button was 1px smaller than the button it was attached to, when they should be the same height, right?

[Feichtmeier]

Imo ideal would be if it would behave like material buttons they also don't change in size

How do you mean? Before this change, the dropdown button was 1px smaller than the button it was attached to, when they should be the same height, right?

I need to double check, and maybe I didnt look correctly into it, but it looks like now the buttons do not inherent their own size anymore, which makes them shrink to 0 or to infinity whatever the parent widget says. I think, as they immitate buttons, they should look and behave like buttons, which includes that their height is fixed and their width has a minimum

[ashuntu]

I need to double check, and maybe I didnt look correctly into it, but it looks like now the buttons do not inherent their own size anymore, which makes them shrink to 0 or to infinity whatever the parent widget says. I think, as they immitate buttons, they should look and behave like buttons, which includes that their height is fixed and their width has a minimum

Right now the row I think is actually expanding infinitely, which causes a render error and so they aren't drawn at all. I have a fix for this I'll make a PR for.

But just to be clear, are you okay with the dropdown button matching the height of the button it is attached to? (i.e. the screenshot in #1051)

[Feichtmeier]

I need to double check, and maybe I didnt look correctly into it, but it looks like now the buttons do not inherent their own size anymore, which makes them shrink to 0 or to infinity whatever the parent widget says. I think, as they immitate buttons, they should look and behave like buttons, which includes that their height is fixed and their width has a minimum

Right now the row I think is actually expanding infinitely, which causes a render error and so they aren't drawn at all. I have a fix for this I'll make a PR for.

But just to be clear, are you okay with the dropdown button matching the height of the button it is attached to? (i.e. the screenshot in #1051)

thank you!
yes, they should have the same height as normal material buttons we currently theme
I think there is even some button height property in the button style in the theme
I build your branch with the action and take a look

[Feichtmeier]

Yes it's working :) Great!