Fix Authelia OIDC login by implementing secure state and nonce #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@alxlion pls review |
Exceluyi
approved these changes
Dec 31, 2025
Exceluyi
left a comment
Exceluyi
left a comment
There was a problem hiding this comment.
@Excellencedev Works perfectly fine for me !
Just fix formatting issues
Author
|
@Exceluyi thanks for confirming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #143 where Authelia OIDC login fails due to a missing or weak
stateparameter.Changes include:
state(base64 encoded) inUserOidcAuth.new/2.noncefor additional security and passes it toOidcc.stateparameter inUserOidcAuth.callback/2against the session value to prevent CSRF attacks.UserOidcAuthTestto verify the presence of security parameters in the session and proper error handling./claim #143