Fix factories being able to build their upgrades as a unit #6869
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Spawn
uab0102and give the following order to reproduce the bug:Description of the proposed changes
UpgradeOnlyCategoryfor all 60 factories.UpgradeOnlyCategorylogic intoCheckBuildRestrictions, as that is the only place where it is needed since it only matters forFactoryBuildandBuildMobileorders. This simplifies the logic overall.OnStartBuildreports a failure. In particular this fixed errors when the factory was ordered to build (not upgrade) a factory upgrade andUpgradeOnlyCategorylogic was not inCheckBuildRestrictions.Testing done on the proposed changes
Test hives again since the logic added by #6709 was changed. Use xrb0104.
Test that factories cannot factory build their own upgrades. Use uab0102.
Checklist