Add method to check if Tx FIFO/QUEUE is full #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evading
force-pushed
the
work/evading/tx-buffer-full
branch
from
c39cfbb to
a5c7c4f
Compare
epontan
reviewed
Apr 15, 2025
epontan
requested changes
Apr 15, 2025
Collaborator
epontan
left a comment
epontan
left a comment
There was a problem hiding this comment.
Looks good, just a tiny comment.
To help when diagnosing the reason for a failed transmission, the TFQF, Tx FIFO/Queue Full, status is exposed through the DynAux trait.
evading
force-pushed
the
work/evading/tx-buffer-full
branch
from
a5c7c4f to
1fbd8d7
Compare
Contributor
Author
|
@Ironedde would you mind taking a look at this? |
Contributor
|
Absolutely! LGTM 👍 |
Ironedde
added a commit
to Ironedde/mcan-clone
that referenced
this pull request
Apr 23, 2025
- Add method to query the Tx FIFO/Queue full status (GrepitAB#56)
Merged
Ironedde
added a commit
that referenced
this pull request
Apr 23, 2025
### Added - Add method to query the Tx FIFO/Queue full status (#56)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help when diagnosing the reason for a failed transmission, the TFQF, Tx FIFO/Queue Full, status is exposed through the DynAux trait.
Thank you!
Thank you for your contribution.
Please make sure that your submission includes the following:
Must
errorsorwarnings.cargo +stable fmtwas run.cargo +stable clippyyields nowarnings.CHANGELOG.mdin the proper section.newly added features and code.