Skip to content

Conversation

@slashtangent
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Fixes an issue where if you selected "Maybe Later" about starting ZM it would still progress you to ZM-2 even though you never watched the cs.
Select Maybe Later = Option 0
Select Start ZM = Option 1

Steps to test these changes

  1. !setrank 6 or higher
  2. !zone <Sea Serpent Grotto>
  3. Zone into Norg.
  4. Select "Maybe Later" observe you're still on "The New Frontier"
  5. Rezone into Norg and start ZM observe you are on now ZM 2 after the CS.

@Xaver-DaRed
Copy link
Contributor

Unless we introduce a way to start it after, this will only cause issues downstream

@slashtangent
Copy link
Contributor Author

Everytime you zone into Norg it will play cs 1 until you start ZM with this fix.

@slashtangent
Copy link
Contributor Author

FWIW this behavior matches retail captures minus spawning the book when you say maybe later.

Mission Zilart 1 - The New Frontier
https://youtu.be/1wc4V56tboc
https://www.dropbox.com/s/8p4i6gxf3k6jba9/Mission%20-%20ZM1%20-%20The%20New%20Frontier.zip?dl=0

@WinterSolstice8
Copy link
Contributor

you need to update the RoZ test similar to the CoP one for Tales' Beginnings
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants