-
Notifications
You must be signed in to change notification settings - Fork 796
Bomb Queen fight rework #9005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: base
Are you sure you want to change the base?
Bomb Queen fight rework #9005
Conversation
74fb47d to
68d81d6
Compare
This PR reworks the Bomb Queen fight to have more retail accuracy. The levels, HP, Gil, behavior, delay, base DMG, summon times, pet behavior, Self Destruct damage has all been adjusted to reflect retail accuracy.
68d81d6 to
0e0529d
Compare
| mobskillObject.onMobWeaponSkill = function(target, mob, skill) | ||
| local damage = mob:getHP() / 3 | ||
|
|
||
| -- Bomb Princes, Princesses, and Bastards do 1 for 1 damage of their HP on self-destruct. It's also breath damage, which hasn't been changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have not had time to comb through the captures yet. Was this tested with something that gives -% breath damage? Or is it more so ignoring %DMG modifiers like Shell?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bahamut hose with -5% BDT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 3rd video shows it, but I noticed early on that Shell and MDT didn't change the static damage coming from the pets.
It's all the same skill ID too unfortunately compared to regular bombs.
It never varied, unlike the Volcanic Bombs. While Volcanic Bomb HP conversion allows for far more damage, the damage itself seems to vary in some way as if there is a lower and upper limit even for the same amount of HP.
| local mobskillObject = {} | ||
|
|
||
| mobskillObject.onMobSkillCheck = function(target, mob, skill) | ||
| if mob:isMobType(xi.mobType.NOTORIOUS) or mob:getHPP() >= 90 then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to check the skill lists to see where else this skill is being used. If other bomb NMs are using it, they will need their own skill list or something to prevent them from blowing up if they are not supposed to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have confirmed Volcanic bombs also blow up above 90%.
They also do significantly more damage on the hp conversion than other bombs.
The Bomb Queen pets naturally use their TP to blow up above 90%.
I think Bomb King has also been shown to blow up above 90% from Skold's testing.
The 90% thing could be bullshit, or wildly conditional depending on the mob.
I know the damage conversion has nothing to do with mob level due to Friar's Lanterns.
I'll likely be doing a deep dive on this for the skill rewrite. Including if all of it is breath damage, or some of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interestingly enough the JP wiki has Blue Mage Self Destruct listed as breath damage.
What do they know.........
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to check the skill lists to see where else this skill is being used. If other bomb NMs are using it, they will need their own skill list or something to prevent them from blowing up if they are not supposed to.
It's easy enough remove it if they aren't supposed to have it but I don't think the check should be in here. It was preventing NMs (like Bomb King) who do use this self destruct from being able to explode.
I affirm:
What does this pull request do?
This PR reworks the Bomb Queen fight to have more retail accuracy.
The levels, HP, Gil, behavior, delay, base DMG, summon times, pet behavior have all been adjusted for retail accuracy.
Bomb Queen will properly stay in place and draw in her enemies as needed.
Self Destruct damage has all been adjusted for her pets to do 1 for 1 damage.
Self Destruct has been shown to do breath damage on these mobs, but has not been adjusted for that.
More research will need to be done on Self Destruct for the ability rewrite.
Using all of my own caps and testing.
https://www.dropbox.com/scl/fo/7ndul3e1p4vqmwvbp3qrg/ADT9q1LuH-Yl_ukt19ptcSA?rlkey=yqukc6gri3wxpexasjzyoqcs8&st=i5c4k7i1&dl=0
https://youtu.be/uqdaG2Kq6dk
https://youtu.be/0S19_Pwy3nY
https://youtu.be/SCFsr-bohpA
Steps to test these changes
Pop bomb queen a feel the burn.