Improve pjit #299
Open
Improve pjit #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the pjit functionality by adding an option to deactivate numba njit, refactoring for readability, and increasing the progress bar sleep time.
- Added a conditional decorator to optionally apply numba.njit via a new parameter.
- Refactored the pjit wrapper and progress callback mechanism.
- Adjusted sleep timing in the progress callback to slow down updates.
alphatims/utils.py
Outdated
| return wrapper(_func) | ||
|
|
||
|
|
||
| def conditional_njit(use_numba: boolean=True, **kwargs) -> Callable: |
There was a problem hiding this comment.
The type hint 'boolean' is not standard in Python; please change it to 'bool' to maintain consistency and correctness.
Suggested change
| def conditional_njit(use_numba: boolean=True, **kwargs) -> Callable: | |
| def conditional_njit(use_numba: bool=True, **kwargs) -> Callable: |
alphatims/utils.py
Outdated
| subsequently passed to the original function. | ||
| """ | ||
|
|
||
| # TODO this method never resets threads |
There was a problem hiding this comment.
Consider addressing the thread reset behavior in the wrapper function to avoid potential issues with stale thread states when reusing the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.