Final-Capstone-Front-end #17

Irirwanirira · 2023-03-16T22:26:46Z

This Pr request consists of:

Link to the Front end Pull Request

Fetch API created from the backend side
Create React components
Use the redux toolkit to fetch data
Add functionalities that allow the user to add books
Add functionality that allows a user to delete a book
Add functionality That allows users to reserve a book

Thank you for Reviewing our project

…nt-end into set-up

Set up

Set user authentication

…nt-end into dev

Authentication login signup

…nt-end into dev

Working

Add workingreservestyle

Styles

Style the book section

Meltrust

Hi @Irirwanirira ,

Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!

To highlight:

Nice code organization ✔️
App is working well✔️
Good readme ✔️
Nice frontend implementation✔️

You are really close to finishing the Microverse program!! Keep it up! 👍👍👍

After implementing the requested changes, please submit another review request. ♻️

Check the comments under the review.

Cheers and Happy coding!👏👏👏

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the previous reviews unless it is requested otherwise.

Meltrust · 2023-03-16T23:34:33Z

src/component/addBook/AddBook.jsx

+import Input from './reusable/inputFields/input';
+import isUserSigned from '../../helpers/auth';
+
+const AddBook = () => {


When I want to add a picture to a book that I'm creating, if the image is high resolution it will overflow the frontend containers:

This issue is more prominent in the mobile view.

Kindly, add some styling so the image has limits and it does not overflow. 👍

Meltrust · 2023-03-16T23:37:44Z

README.md

+### Run tests
+
+To run tests, run the following command:
+
+```sh
+  rspec spec/
+```


This command is meant for the backend project. Since this is the frontend project, kindly remove it. 👍

Omitted accordingly.

Meltrust · 2023-03-16T23:39:23Z

src/component/addBook/reusable/modal/Modal.css

+/* .backdrop {
+    display: flex;
+    flex-direction: column;
+}
+ */


Kindly, remove this commented code in order to improve the repo's cleanliness. 👍

Meltrust · 2023-03-16T23:40:18Z

src/component/signup/SignUp.css

Kindly, remove the commented code present in this file in order to improve the repo's cleanliness. 👍

Meltrust

Hi @Irirwanirira,

Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!

To highlight:

Nice code organization ✔️
App is working well✔️
Good readme ✔️
Beautiful frontend ✔️

You are really close to finishing the Microverse program!! Keep it up! 👍👍👍

After implementing the requested changes, please submit another review request. ♻️

Check the comments under the review.

Cheers and Happy coding!👏👏👏

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the previous reviews unless it is requested otherwise.

Meltrust · 2023-03-17T05:38:51Z

README.md

+
+<p align="right">(<a href="#readme-top">back to top</a>)</p>
+
+<!-- SUPPORT -->


Since the last review, this pull request has not suffered any changes or commits. Kindly implement the comments featured on the last review. 👍

Peace

netlify · 2023-03-19T16:33:11Z

✅ Deploy Preview for fastidious-biscotti-61dbed ready!

Name	Link
🔨 Latest commit	`a4963b2`
🔍 Latest deploy log	https://app.netlify.com/sites/fastidious-biscotti-61dbed/deploys/641acde90ef2da0008160aa4
😎 Deploy Preview	https://deploy-preview-17--fastidious-biscotti-61dbed.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Irirwanirira and others added 30 commits March 3, 2023 15:39

Initialize project using Create React App

cff5032

Merge branch 'dev' of https://github.com/NurkaAmre/Final-Capstone-Fro…

3d5ac14

…nt-end into set-up

Modified readme

bfededa

Modify Readme

6db1877

Install react-redux

a8c7714

Set Linters and Add packages

e42439a

Merge pull request #1 from NurkaAmre/set-up

1b90850

Set up

Set user authentication

5479f84

Define bbutton types

562f996

Merge branch 'feature01' into dev

9a7d9b1

Merge pull request #2 from NurkaAmre/feature01

66613ea

Set user authentication

Merge branch 'dev' of https://github.com/NurkaAmre/Final-Capstone-Fro…

520a647

…nt-end into dev

Implement App.js

b4b2638

Add user seession implementation

964dc52

Implement login and signup

25f56c8

Implemted navbar it was hard uff

c35dc66

Fix linter errors

f245cbd

Merge pull request #3 from NurkaAmre/feature03

8fa7173

Authentication login signup

Merge branch 'dev' of https://github.com/NurkaAmre/Final-Capstone-Fro…

8aa263f

…nt-end into dev

Implement login

30e1274

User slice

a9a3aae

Add authentication helper

396c2f4

Add style login

2f109c8

Fetch books

1642903

Navigation panel

2c7608f

Add Reservation pages

2ad4ecc

Implement home page

7644261

Fix linter errors

93f2b59

Fix linter error

a9c3cb3

Fix linter error

28bcf5e

NurkaAmre and others added 12 commits March 17, 2023 02:45

Small styling

5ec26a3

Merge branch 'dev' into working

258df02

Merge pull request #14 from NurkaAmre/working

17e25af

Working

Merge pull request #15 from NurkaAmre/workingstylereserve

513b896

Add workingreservestyle

Merge pull request #13 from NurkaAmre/Styles

2f84e6f

Styles

Style the book section

d25b5a5

Merge branch 'dev' into bookStyle

3c69fa7

Merge pull request #16 from NurkaAmre/bookStyle

4d09a6e

Style the book section

Fix linters

791c48b

Update ReadMe

7be4e1b

Update README.md

eed2a60

Update README.md

fd20801

Meltrust suggested changes Mar 16, 2023

View reviewed changes

Meltrust suggested changes Mar 17, 2023

View reviewed changes

Irirwanirira and others added 12 commits March 17, 2023 14:24

Modify styles

947d0d7

Update README.md

19badd4

Update README.md

deb008a

Update README.md

d771ce3

Update README.md

f89fc61

Update Modal.css

e432495

Update SignUp.css

49a590d

My loved style

cac5be9

Finish styling

03423be

Merge branch 'dev' into peace

0621d22

Merge pull request #18 from NurkaAmre/peace

65ef1d4

Peace

Fix linter errors

4430af7

NurkaAmre added 3 commits March 19, 2023 22:41

Update README.md

b6e46e8

Update README.md

e909794

Update LICENSE

a4963b2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Final-Capstone-Front-end #17

Final-Capstone-Front-end #17

Uh oh!

Irirwanirira commented Mar 16, 2023 •

edited

Loading

Uh oh!

Meltrust left a comment

Uh oh!

Meltrust Mar 16, 2023 •

edited by chuaindia

Loading

Uh oh!

chuaindia Mar 17, 2023

Uh oh!

Meltrust Mar 16, 2023 •

edited by chuaindia

Loading

Uh oh!

chuaindia Mar 17, 2023

Uh oh!

Meltrust Mar 16, 2023 •

edited by chuaindia

Loading

Uh oh!

chuaindia Mar 17, 2023

Uh oh!

Meltrust Mar 16, 2023

Uh oh!

Meltrust left a comment

Uh oh!

Meltrust Mar 17, 2023

Uh oh!

netlify bot commented Mar 19, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants


		<p align="right">(<a href="#readme-top">back to top</a>)</p>

		<!-- SUPPORT -->

Final-Capstone-Front-end #17

Are you sure you want to change the base?

Final-Capstone-Front-end #17

Uh oh!

Conversation

Irirwanirira commented Mar 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Meltrust left a comment

Choose a reason for hiding this comment

To highlight:

You are really close to finishing the Microverse program!! Keep it up! 👍👍👍

After implementing the requested changes, please submit another review request. ♻️

Uh oh!

Meltrust Mar 16, 2023 • edited by chuaindia Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chuaindia Mar 17, 2023

Choose a reason for hiding this comment

Uh oh!

Meltrust Mar 16, 2023 • edited by chuaindia Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chuaindia Mar 17, 2023

Choose a reason for hiding this comment

Uh oh!

Meltrust Mar 16, 2023 • edited by chuaindia Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chuaindia Mar 17, 2023

Choose a reason for hiding this comment

Uh oh!

Meltrust Mar 16, 2023

Choose a reason for hiding this comment

Uh oh!

Meltrust left a comment

Choose a reason for hiding this comment

To highlight:

You are really close to finishing the Microverse program!! Keep it up! 👍👍👍

After implementing the requested changes, please submit another review request. ♻️

Uh oh!

Meltrust Mar 17, 2023

Choose a reason for hiding this comment

Uh oh!

netlify bot commented Mar 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for fastidious-biscotti-61dbed ready!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Irirwanirira commented Mar 16, 2023 •

edited

Loading

Meltrust Mar 16, 2023 •

edited by chuaindia

Loading

Meltrust Mar 16, 2023 •

edited by chuaindia

Loading

Meltrust Mar 16, 2023 •

edited by chuaindia

Loading

netlify bot commented Mar 19, 2023 •

edited

Loading