Skip to content

[DatamanClient] Add dataman running status check before read/write #26128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
w2016561536 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[DatamanClient] Add dataman running status check before read/write #26128

w2016561536 wants to merge 1 commit into from
+29 −6

Conversation

@w2016561536
Copy link

@w2016561536 w2016561536 commented Dec 16, 2025 •
edited
Loading

Solved Problem

Fixes #{Github issue ID}
[Bug] Operation timeout, aborting transfer #24287

Solution

Add dataman running status check before DatamanClient perform read/write

Changelog Entry

For release notes:

Feature/Bugfix 
[Dataman] Fix DatamanClient module waiting for dataman response when storage unavailable

Documentation: Need to clarify page ... / done, read docs.px4.io/...

Alternatives

Test coverage

N/A

Context

Related links, screenshot before/after, video

dakejahl
dakejahl reviewed Dec 16, 2025
View reviewed changes
src/modules/dataman/dataman.cpp
return PX4_OK;
}
return PX4_ERROR;
}
Copy link
Contributor

@dakejahl dakejahl Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make this return bool and you can return the is_running() output directly. Also the dm_operations_data.running should be made an atomic type.

Copy link
Author

@w2016561536 w2016561536 Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your advice. Now it's frady for review.

@w2016561536 w2016561536 reopened this Dec 17, 2025
@w2016561536
Copy link
Author

w2016561536 commented Dec 17, 2025

Well, it seems some compiler could not find function definition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dakejahl dakejahl dakejahl left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@w2016561536 @dakejahl