Skip to content

Conversation

@Claudio-Chies
Copy link
Member

Solved Problem

Fixes #N/A

Solution

Introduce documentation for the device tracking feature in PX4, detailing how it collects and logs metadata from external hardware devices connected via DroneCAN.

Alternatives

N/A

Test coverage

N/A

Context

Related links: Device Tracking Documentation

dakejahl
dakejahl previously approved these changes Dec 19, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces comprehensive documentation for PX4's device tracking feature, which automatically collects and logs metadata from DroneCAN-connected hardware devices. The documentation explains how to view device information in real-time and access it from flight logs.

Key changes:

  • New dedicated documentation page explaining device tracking capabilities and use cases
  • Cross-references added to CAN and DroneCAN documentation linking to the new device tracking page
  • Navigation entry added to SUMMARY.md for discoverability

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.

File Description
docs/en/advanced_config/device_tracking.md New comprehensive documentation covering device tracking overview, use cases, real-time monitoring, and flight log analysis
docs/en/can/index.md Added paragraph introducing device tracking capabilities for CAN devices with link to detailed documentation
docs/en/dronecan/index.md Added bullet point to benefits list highlighting automatic device tracking with cross-reference
docs/en/SUMMARY.md Added navigation entry for the new device tracking documentation page

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

For this reason it is very robust even over longer cable lengths (on large vehicles), and avoids a single point of failure.
CAN also allows status feedback from peripherals and convenient firmware upgrades over the bus.

PX4 has the ability to track and log detailed information from CAN devices, including firmware versions, hardware versions, and serial numbers.
Copy link

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double space detected between "to" and "track". Should be a single space for proper formatting.

Suggested change
PX4 has the ability to track and log detailed information from CAN devices, including firmware versions, hardware versions, and serial numbers.
PX4 has the ability to track and log detailed information from CAN devices, including firmware versions, hardware versions, and serial numbers.

Copilot uses AI. Check for mistakes.
Comment on lines 61 to 62
Device information is automatically logged to flight logs.
You can extract it using [pyulog](https://github.com/PX4/pyulog), though note that fields like vendor name, model name, and serial number are stored as char arrays and require additional parsing.
Copy link

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the project guidelines, lines should end at sentence boundaries (Semantic Line Breaks). This line contains two sentences. Split after "to flight logs." so each sentence is on its own line.

Copilot generated this review using guidance from repository custom instructions.

### Real-Time Monitoring

You can view device information in real-time using the [MAVLink Shell](../debug/mavlink_shell.md) or console:
Copy link

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the project guidelines, tool names should be italicized (emphasis). "MAVLink Shell" is a tool and should be styled as MAVLink Shell.

Copilot generated this review using guidance from repository custom instructions.
Copy link
Contributor

@hamishwillee hamishwillee Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not correct. I will fix our instructions. Ignore.

## Flight Log Analysis

Device information is automatically logged to flight logs.
You can extract it using [pyulog](https://github.com/PX4/pyulog), though note that fields like vendor name, model name, and serial number are stored as char arrays and require additional parsing.
Copy link

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the project guidelines, tool names should be italicized (emphasis). "pyulog" is a tool and should be styled as pyulog.

Copilot generated this review using guidance from repository custom instructions.
@@ -0,0 +1,68 @@
# Device Tracking

PX4 can track and log detailed information about external hardware devices connected to the flight controller.
Copy link
Contributor

@hamishwillee hamishwillee Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Why is this in advanced configuration? I mean it doesn't look like you have to do any configuration. How about under logging? - https://docs.px4.io/main/en/debug/

@@ -0,0 +1,68 @@
# Device Tracking
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device Tracking sounds like it could equally well be a "Find my drone" service. Can we find a better name?

I was thinking about something like "Asset Tracking & Logging"? We want it to be something instantly recognisable. Very open to suggestions.

@github-actions
Copy link

No flaws found

@@ -0,0 +1,67 @@
# Device Tracking

<Badge type="tip" text="main (planned for: PX4 v1.18)" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. What version of PX4 will this first appear in? I have put v1.18 but needs to be correct.
  2. Can you add a release note. I would expect this to go in https://docs.px4.io/main/en/releases/main if this is in 1.18 and we'd create a new document if it is going into 1.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants