-
Notifications
You must be signed in to change notification settings - Fork 532
feat: add signing and verifying example used to demonstrate AgentCard signing and verifying
#420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add signing and verifying example used to demonstrate AgentCard signing and verifying
#420
Conversation
This example demonstrated: - Signing Agent Cards on the server side. - Verifying Agent Card signatures on the client side.
Summary of ChangesHello @sokoliva, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers a robust example of an Agent-to-Agent (A2A) agent that integrates AgentCard signing and verification. The primary goal is to illustrate how agents can establish trust by cryptographically signing their identity cards, which clients can then verify. This example covers the full lifecycle from key generation and server-side signing of both public and extended agent cards, to client-side fetching and validation of these signatures, thereby enhancing the security posture of A2A interactions. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a valuable example demonstrating agent card signing and verification. The implementation is well-structured, including a Containerfile and a comprehensive README.md. My review focuses on improving dependency management, container security, and adherence to standards like RFC 7515 for JWTs. I've also included minor suggestions for code style and error handling to enhance the quality of the example.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ures-samples' into agent-card-signatures-samples
…d newlines to README.md
… formatting changes by running a `ruff format` command
…This will be changed back to WARN before merging to main
signing and verifying example used to demonstrate AgentCard signing and verifying
signing and verifying example used to demonstrate AgentCard signing and verifyingsigning and verifying example used to demonstrate AgentCard signing and verifying
…Make formatting changes.
This change introduces a new agent whose
agent_cardis signed on the server side usingsignerfunction created bycreate_agent_card_signerand verified on the client side using asignature_verifierfunction created bycreate_signature_verifier.Relevant link: Agent Card Signing
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.