fix: virtual-ns-prefix into sim CRD #209
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.




Related Links
Description and Rationale
Test Steps
Other Notes
As in fix: make the driver secrets part of the CRD #208 this is arguably not a patch bump but since the CRD is not installed in "real" clusters I think it's fine
I waffled back and forth on whether to make
virtual_ns_prefix"required", "required with default", or "optional". Optional would be the most API-preserving, but I do think this "should" be a required field. Then I took the default out because the serde default stuff is a pain, but this way users can (if they want) write their own tools for interacting with simkube and get sane-ish behaviour. The default is then re-specified in skctl which is kindof annoying but whatever.Re-ordered some stuff to make it alphabetical
I certify that this PR does not contain any code that has been generated with GitHub Copilot or any other AI-based code generation tool, in accordance with this project's policies.