Skip to content

Conversation

@drmorr0
Copy link
Contributor

@drmorr0 drmorr0 commented Dec 17, 2025

Related Links

Description and Rationale

  • Move the virtual ns prefix out of the CLI arguments and into the CRD, because the CRD is easier to interact with/change on a per-sim basis

Test Steps

  • make test passes
  • skctl run works as expected

Other Notes

  • As in fix: make the driver secrets part of the CRD #208 this is arguably not a patch bump but since the CRD is not installed in "real" clusters I think it's fine

  • I waffled back and forth on whether to make virtual_ns_prefix "required", "required with default", or "optional". Optional would be the most API-preserving, but I do think this "should" be a required field. Then I took the default out because the serde default stuff is a pain, but this way users can (if they want) write their own tools for interacting with simkube and get sane-ish behaviour. The default is then re-specified in skctl which is kindof annoying but whatever.

  • Re-ordered some stuff to make it alphabetical

  • I certify that this PR does not contain any code that has been generated with GitHub Copilot or any other AI-based code generation tool, in accordance with this project's policies.

@drmorr0
Copy link
Contributor Author

drmorr0 commented Dec 17, 2025

Kubernetes Object DAG

%%{init: {'themeVariables': {'mainBkg': '#ddd'}}}%%
graph LR

classDef default color:#000
subgraph global
  direction LR
  global/simkube[<b>Namespace</b><br>simkube]
%% DELETED OBJECTS START
%% DELETED OBJECTS END
end

subgraph sk-tracer
  direction LR
  simkube/sk-tracer-svc[<b>Service</b><br>sk-tracer-svc]
  simkube/sk-tracer-depl[<b>Deployment</b><br>sk-tracer-depl]
  simkube/sk-tracer-sa[<b>ServiceAccount</b><br>sk-tracer-sa]
  sk-tracer/sk-tracer-crb[<b>ClusterRoleBinding</b><br>sk-tracer-crb]
  simkube/sk-tracer-tracer-config[<b>ConfigMap</b><br>sk-tracer-tracer-config]
  simkube/sk-tracer-sa--->simkube/sk-tracer-depl
  sk-tracer/sk-tracer-crb--->simkube/sk-tracer-depl
  simkube/sk-tracer-tracer-config--->simkube/sk-tracer-depl
%% DELETED OBJECTS START
%% DELETED OBJECTS END
end

subgraph sk-ctrl
  direction LR
  simkube/sk-ctrl-depl[<b>Deployment</b><br>sk-ctrl-depl]
  simkube/sk-ctrl-sa[<b>ServiceAccount</b><br>sk-ctrl-sa]
  sk-ctrl/sk-ctrl-crb[<b>ClusterRoleBinding</b><br>sk-ctrl-crb]
  simkube/sk-ctrl-sa--->simkube/sk-ctrl-depl
  sk-ctrl/sk-ctrl-crb--->simkube/sk-ctrl-depl
%% DELETED OBJECTS START
%% DELETED OBJECTS END
end

global--->sk-tracer
global--->sk-ctrl

%% STYLE DEFINITIONS START
%% STYLE DEFINITIONS END
Loading

New object
Deleted object
Updated object
Updated object (causes pod recreation)

Detailed Diff

@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.60%. Comparing base (97cabf7) to head (c4fb213).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sk-cli/src/run.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
- Coverage   75.63%   75.60%   -0.04%     
==========================================
  Files          58       58              
  Lines        3292     3291       -1     
  Branches      164      164              
==========================================
- Hits         2490     2488       -2     
- Misses        696      697       +1     
  Partials      106      106              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@drmorr0 drmorr0 force-pushed the drmorr/virtual-ns-prefix-to-crd branch from 11037e2 to a2b81cf Compare December 17, 2025 06:44
Base automatically changed from ian/mwc-updates to main December 17, 2025 19:14
@drmorr0 drmorr0 force-pushed the drmorr/virtual-ns-prefix-to-crd branch from a2b81cf to c4fb213 Compare December 17, 2025 19:37
@drmorr0
Copy link
Contributor Author

drmorr0 commented Dec 17, 2025

@ogorman89 just FYI, this is the change we discussed in the last PR

@drmorr0 drmorr0 merged commit bd46822 into main Dec 17, 2025
8 of 9 checks passed
@drmorr0 drmorr0 deleted the drmorr/virtual-ns-prefix-to-crd branch December 17, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants