-
Notifications
You must be signed in to change notification settings - Fork 543
Bump test dependencies to resolve System.Net.Http vulnerability, update workflows and README #692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bump test dependencies to resolve System.Net.Http vulnerability, update workflows and README #692
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses a security vulnerability (CVE-2018-8292) in the transitive dependency System.Net.Http 4.3.0 by upgrading test dependencies to their latest versions, and resolves documentation issues related to Windows CMD shell formatting of global.json files. The changes include comprehensive version updates throughout test files and workflows to use .NET 8.0, 9.0, and 10.0.
Key Changes:
- Upgraded test dependencies: Microsoft.NET.Test.Sdk to 18.0.1, MSTest.TestAdapter and MSTest.TestFramework to 4.0.2, successfully eliminating the System.Net.Http 4.3.0 vulnerability
- Updated all test files and workflows from .NET 6.0/7.0 references to 9.0/10.0 for current relevance
- Consolidated workflow test jobs to reduce duplication while maintaining comprehensive coverage across all supported operating systems
- Added documentation note about Windows shell requirements for
global.jsongeneration
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
__tests__/e2e-test-csproj/test.csproj |
Updated test dependencies to latest secure versions (Microsoft.NET.Test.Sdk 18.0.1, MSTest packages 4.0.2) |
__tests__/e2e-test-csproj/packages.lock.json |
Regenerated lock file with updated dependencies targeting net10.0, removing vulnerable System.Net.Http 4.3.0 |
__tests__/e2e-test-csproj/Test.cs |
Fixed assertion parameter order to follow MSTest conventions (expected, actual) |
__tests__/e2e-test-csproj/AssemblyInfo.cs |
Added DoNotParallelize attribute for sequential test execution |
__tests__/verify-dotnet.ps1 |
Added support for .NET 10.0 framework mapping |
__tests__/setup-dotnet.test.ts |
Updated test version references from 6.0 to 10.0 |
__tests__/installer.test.ts |
Updated test version references from 3.1/6.0 to 10.0 for consistency |
README.md |
Updated actions/checkout from v5 to v6, version examples to 8.0/9.0/10.0, and added Windows shell guidance |
.github/workflows/test-dotnet.yml |
Updated matrix to test .NET 8.0, 9.0, 10.0 instead of 6.0, 7.0, 8.0, 9.0 |
.github/workflows/e2e-tests.yml |
Consolidated test jobs and updated versions to 9.0/10.0, expanding OS matrix to include ubuntu-latest and macos-latest |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description:
This PR includes:
Bumps test dependencies in
__tests__/e2e-test-csproj/test.csprojto their latest available versions:Microsoft.NET.Test.Sdkfrom 15.5.0-preview-20170810-02 to 18.0.1.MSTest.TestAdapterfrom 1.1.18 to 4.0.2.MSTest.TestFrameworkfrom 1.1.18 to 4.0.2.Updates workflow configuration for improved clarity and removes references to older .NET versions.
Updates the README:
pwshorbashwhen generating a temporaryglobal.jsonon Windows to avoid formatting issues.Related issues:
#676
#683
Check list: