This repository was archived by the owner on Sep 21, 2023. It is now read-only.
types: Fix onSuccess callback #482
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we have a `code` property on the `GoogleLoginResponse` interface that isn't actually there and is just a hack for people doing the offline flow. Additionally, if using the online flow in TypeScript you can't safely access any of the properties and need to cast the argument of the onSuccess callback to get them. This PR fixes these issues by properly handling the `responseType` property that determines what the `onSuccess` callback's argument is.
sammce
approved these changes
Sep 27, 2021
ElvisKrop
approved these changes
Oct 31, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have a
codeproperty on theGoogleLoginResponseinterface that isn't actually there and is just a hack for people doing the offline flow. Additionally, if using the online flow in TypeScript you can't safely access any of the properties and need to cast the argument of the onSuccess callback to get them.This PR fixes these issues by properly handling the
responseTypeproperty that determines what theonSuccesscallback's argument is.This allows us to do this in TypeScript without errors (currently, this errors as TypeScript is not sure whether res is a GoogleLoginResponse or a GoogleLoginResponseOffline):
While still erroring about bad property accesses when the responseType is code:
But of course still allowing us to get the code when responseType is code: