test: flaky unit test #26310
Merged
test: flaky unit test #26310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name=".github/workflows/pr.yml">
<violation number="1" location=".github/workflows/pr.yml:4">
P1: Removing `pull_request_review` trigger breaks the external contributor approval workflow. The trust-check job relies on this trigger to re-run CI after a maintainer approves an external contributor's PR. Without it, external PRs will remain blocked even after approval.
Additionally, references to `github.event_name == 'pull_request_review'` in concurrency and trust-check conditions are now dead code since this event will never trigger the workflow.
If intentionally removing this flow, also clean up the dead code references to `pull_request_review` in the concurrency group, cancel-in-progress, and trust-check job.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
Found 3 test failures on Blacksmith runners: Failures
|
Contributor
E2E results are ready! |
anikdhabal
changed the title
anikdhabal
changed the title
anikdhabal
force-pushed
the
cache-build
branch
from
6c08279 to
8adb6d3
Compare
Remove node_modules from cache path in action.yml
anikdhabal
changed the title
Updated mocks for various services and constants in tests, ensuring accurate behavior for both hosted and self-hosted scenarios.
Contributor
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/trpc/server/routers/viewer/organizations/intentToCreateOrg.handler.test.ts">
<violation number="1">
P1: `vi.mock()` inside `beforeEach()` won't work as intended. Vitest hoists `vi.mock()` calls to the top of the file at compile time, so placing it inside `beforeEach()` doesn't dynamically change the mock per describe block. The mock is set once at module load time.
For per-describe mock variations, use `vi.doMock()` (which is not hoisted) with dynamic imports, or export the constant through a getter function that can be mocked with `vi.spyOn()`/`vi.mocked().mockReturnValue()`.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
packages/trpc/server/routers/viewer/organizations/intentToCreateOrg.handler.test.ts
Show resolved
Hide resolved
keithwillcode
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Updated intentToCreateOrg tests with explicit mocks to reduce flakes and cover hosted/self-hosted flows.
Written for commit bc488f8. Summary will update on new commits.