-
Notifications
You must be signed in to change notification settings - Fork 11.4k
perf: optimize postgres health check in all CI workflows #26343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: optimize postgres health check in all CI workflows #26343
Conversation
Co-Authored-By: keith@cal.com <keithwillcode@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: keith@cal.com <keithwillcode@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
E2E results are ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 6 files
What does this PR do?
Optimizes the postgres service container health check configuration across all CI workflows to reduce the "Initialize Containers" step duration.
Analysis of current behavior (from CI job logs):
The bottleneck is the
--health-interval 10ssetting. Docker can't mark a container as "healthy" until a health check actually runs and succeeds. Since postgres typically starts accepting connections within 1-2 seconds (especially with pre-cached images on Blacksmith runners), we're waiting unnecessarily.Changes applied to all 6 workflow files:
e2e.ymle2e-app-store.ymle2e-embed.ymle2e-embed-react.ymle2e-api-v2.ymlapi-v1-production-build.ymlConfiguration changes:
--health-intervalfrom 10s to 2s for faster detection--health-retriesfrom 5 to 15 to maintain tolerance (~30s total)--health-start-period 2sfor startup grace period-h 127.0.0.1 -U postgresExpected improvement: ~16s → ~4-6s for postgres health check per workflow
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Human Review Checklist
--health-start-periodis supported on Blacksmith runners (Docker API 1.48 confirmed in logs)Checklist