-
Notifications
You must be signed in to change notification settings - Fork 11.4k
fix: reduce default Playwright test timeout from 60s to 30s in CI #26345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reduce default Playwright test timeout from 60s to 30s in CI #26345
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
E2E results are ready! |
Co-Authored-By: keith@cal.com <keithwillcode@gmail.com>
6962bcb to
c140df0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 1 file
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="playwright.config.ts">
<violation number="1" location="playwright.config.ts:21">
P2: The comment above this line states the test timeout "should be much higher than sum of expect and navigation timeouts", but the new value (30s) is now equal to (not higher than) the individual step timeouts (navigation: 30s, expect: 30s). Consider updating the comment to reflect the new intentional design choice of failing fast on slow tests rather than accommodating multiple slow operations.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 1 file (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="playwright.config.ts">
<violation number="1" location="playwright.config.ts:16">
P1: The actual changes contradict the PR description. The description states "Step-level timeouts (navigation, action, expect) remain unchanged at 30s", but this line reduces navigation timeout from 30s to 10s in CI. If the intent is to keep step-level timeouts at 30s as stated, this change should be reverted to `30000`. If 10s is intentional, the PR description needs to be updated.</violation>
<violation number="2" location="playwright.config.ts:17">
P1: Same issue as above - this contradicts the PR description which states "Step-level timeouts (navigation, action, expect) remain unchanged at 30s", but this reduces expect timeout from 30s to 10s. Additionally, the comment above states test timeout should be "much higher than sum of expect and navigation timeouts" - with test timeout at 30s and this at 10s, the ratio is tighter than before.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
What does this PR do?
Reduces the default Playwright test timeout in CI from 60s to 30s to fail fast on slow tests, encouraging system improvements rather than waiting for slow operations.
Changes:
This is a simplified version of the original PR - all 1-off timeout overrides and step-level timeout changes have been reverted per Keith's request.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
This change affects CI behavior only. To verify:
Checklist
Human Review Checklist
test.setTimeout()overrides added laterLink to Devin run: https://app.devin.ai/sessions/8df4c87ad80846c9b3d358f520f174ed
Requested by: keith@cal.com (@keithwillcode)