[ML] Downgrade log severity for a batch of recoverable errors #2889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
darius-vil
changed the title
darius-vil
changed the title
Author
|
Closes #2888 |
edsavage
approved these changes
Dec 23, 2025
Contributor
edsavage
left a comment
edsavage
left a comment
There was a problem hiding this comment.
LGTM, just the one comment
| LOG_ERROR(<< "Failed to compute log likelihood (" << this->debug() << ")"); | ||
| LOG_ERROR(<< "samples = " << samples); | ||
| LOG_ERROR(<< "weights = " << weights); | ||
| LOG_DEBUG(<< "Failed to compute log likelihood (" << this->debug() << ")"); |
Contributor
There was a problem hiding this comment.
Should this be LOG_WARN to be consistent with elsewhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.