refactor: use consistent snake_case for issue_number parameter #1702
+26
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the parameter name in assign_copilot_to_issue tool from 'issueNumber' (camelCase) to 'issue_number' (snake_case) to match the naming convention used by all other tools in the issues toolset. This improves API consistency and makes the tool parameters more predictable for users and AI models. Fixes github#1239 Signed-off-by: majiayu000 <1835304752@qq.com>
Collaborator
|
@majiayu000 this change is good, but the generate docs script needs to be run to auto-update the README.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change the parameter name in
assign_copilot_to_issuetool fromissueNumber(camelCase) toissue_number(snake_case) to match the naming convention used by all other tools in the issues toolset.Problem
As noted in #1239, there are inconsistencies in parameter naming across tools. The
assign_copilot_to_issuetool usesissueNumberwhile all other issue-related tools useissue_number.Changes
issueNumbertoissue_numberin:Testing
Fixes #1239