Skip to content

Conversation

@Haarolean
Copy link
Member

@Haarolean Haarolean commented Dec 18, 2025

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Fixes #525

  • Fixed active controller id for KRaft clusters
  • Added a UI indicator for cluster controller type:
Screenshot 2025-12-19 at 05 21 54

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Haarolean Haarolean added this to the 1.5 milestone Dec 18, 2025
@Haarolean Haarolean self-assigned this Dec 18, 2025
@Haarolean Haarolean requested review from a team as code owners December 18, 2025 22:38
@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/frontend Related to frontend changes scope/backend Related to backend changes type/bug Something isn't working area/ux User experiense issues labels Dec 18, 2025
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Dec 18, 2025
@Haarolean Haarolean moved this from Todo to In Review in Release 1.5 Dec 18, 2025
@Haarolean
Copy link
Member Author

@fallen-up PTAL

.build();
.controller(quorumInfo.isPresent() ? ClusterController.KRAFT : ClusterController.ZOOKEEPER);

quorumInfo.ifPresent(i -> stats.quorumLeaderId(i.leaderId()));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would save quoruminfo into stats, just in sake of future.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was my initial idea too, but I decided not to, as QuorumInfo.nodes is an empty collection for some reason, voters was non-empty but quite boring from a data perspective, the rest is just not useful in any way in current implementation. What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still keep it there

@github-project-automation github-project-automation bot moved this from In Review to Changes requested in Release 1.5 Dec 19, 2025
@Haarolean Haarolean requested a review from germanosin December 19, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ux User experiense issues scope/backend Related to backend changes scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/bug Something isn't working type/enhancement En enhancement/improvement to an already existing feature

Projects

Status: Changes requested

Development

Successfully merging this pull request may close these issues.

Don't show active controller for KRaft clusters

3 participants