-
-
Notifications
You must be signed in to change notification settings - Fork 234
Add cluster controller type + fix active node id for KRaft #1586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@fallen-up PTAL |
| .build(); | ||
| .controller(quorumInfo.isPresent() ? ClusterController.KRAFT : ClusterController.ZOOKEEPER); | ||
|
|
||
| quorumInfo.ifPresent(i -> stats.quorumLeaderId(i.leaderId())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would save quoruminfo into stats, just in sake of future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was my initial idea too, but I decided not to, as QuorumInfo.nodes is an empty collection for some reason, voters was non-empty but quite boring from a data perspective, the rest is just not useful in any way in current implementation. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would still keep it there
What changes did you make? (Give an overview)
Fixes #525
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)