Fix geoQuery to apply geohash orderBy before queryBuilder #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where geoQuery would fail when queryBuilder added additional orderBy clauses.
The problem was that startAt([geohash]) only provides one value, but Firestore expects values for ALL orderBy fields in startAt/endAt. When queryBuilder added its own orderBy before the geohash orderBy, the cursor position became invalid.
The fix reorders operations so the geohash orderBy with startAt/endAt is applied first to the base collection reference, then queryBuilder modifications are applied afterward. This ensures the cursor values only apply to the geohash field.