-
Notifications
You must be signed in to change notification settings - Fork 133
Clean up structure/molecule aliases in ASE / MLFF jobs #1354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
10f0627 to
b4f684d
Compare
|
Thanks @esoteric-ephemera for the fix! It looks good to me. I just wanted to mention that the alias+property at the moment does not create any problem since in job1=ForceFieldRelaxMaker(force_field_name="MACE_MP_0B3").make(s)
job2=ForceFieldRelaxMaker(force_field_name="MACE_MP_0B3").make(job1.output.output.structure)
In light of this, I think it may be worth to update jobflow to handle cases like this. The change should be relatively small. What do you think @utf? |
|
Thanks @gpetretto - we could move the |
…rom ionic step properties
ce572da to
8bef978
Compare
Close #1353 by:
structureandmoleculeproperties that get populated bymol_or_structin base ASE / MLFF docsmol_or_structgets populated by alias ifstructureormoleculeis presentmol_or_structin ionic steps, and by specifying eithermol_or_struct,molecule, orstructure