-
Notifications
You must be signed in to change notification settings - Fork 5
Enable observability by default with console logging #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>
Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>
Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>
|
@copilot - remove reference to ENABLE_OBSERVABILITY=true |
|
@copilot ENABLE_A365_OBSERVABILITY_EXPORTER=true should still be required to send logs to the service. Dont make any changes related to that |
Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>
Done. Removed outdated references in commit fee7e8e:
All 122 observability tests continue to pass. |
Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>
Understood. Reverted in commit 988da18 - Current behavior:
All 124 tests pass. |
Observability is now enabled by default with console output, eliminating the need for partners and self-hosting customers to configure
ENABLE_OBSERVABILITYandENABLE_A365_OBSERVABILITYenvironment variables. TheENABLE_A365_OBSERVABILITY_EXPORTER=trueenvironment variable is still required to send telemetry to the Agent365 service.Changes Made
Default behavior:
ENABLE_OBSERVABILITYandENABLE_A365_OBSERVABILITY)ConsoleSpanExporterby defaultENABLE_A365_OBSERVABILITY_EXPORTER=trueANDtokenResolverconfigurationEnvironment variables:
ENABLE_OBSERVABILITYandENABLE_A365_OBSERVABILITY- No longer required (enabled by default)false,0,no, oroffENABLE_A365_OBSERVABILITY_EXPORTER- Still requires explicit=trueto send telemetry to Agent365 servicetrue,1,yes, oronto enableImplementation:
Code quality improvements:
isExplicitlyDisabled()helper to eliminate duplicationObservabilityBuilder.createBatchProcessor()logicisAgent365ExporterEnabled()implementation inexporter/utils.tsTesting
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.