Introduce PowerPlatformConnectorClient2 #2909
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shgogna
commented
May 15, 2025
src/libraries/Microsoft.PowerFx.Connectors/PowerPlatformConnectorClient2.cs
Show resolved
Hide resolved
MikeStall
reviewed
May 15, 2025
| Task<HttpResponseMessage> SendAsync( | ||
| HttpRequestMessage requestMessage, | ||
| PowerPlatformConnectorClient2DiagnosticOptions diagnosticOptions, | ||
| CancellationToken cancellationToken); |
Contributor
There was a problem hiding this comment.
Since this is a public SDK, the interface should be minimal.
Can this method be an extension method that calls into the other "true" one?
That also makes it very clear how they relate.
Contributor
Author
There was a problem hiding this comment.
Moved this to an extension method
jas-valgotar
force-pushed
the
shgogna/powerplatformconnectorsclientv2
branch
from
96e3497 to
20fce4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new version of
PowerPlatformConnectorClientcalledPowerPlatformConnectorClient2. Naming for the new client is open for debate 😄The differences include:
IPowerPlatformConnectorClient2PowerPlatformConnectorClient2BearerTokenProviderPowerPlatformConnectorClient2DiagnosticOptionswhich specifies values that are typically sent by clientsmethod,operationPathAndQuery,headers, andcontentinstead of reusingHttpRequestMessage. This was done to avoid client teams creating a dummy object that would not even get used.GetFirstServerUriextension toOpenApiExtensionsMisc:
OpenApiExtensionsSee: #2908