Skip to content

Conversation

@gvanrossum
Copy link
Collaborator

@gvanrossum gvanrossum commented Dec 30, 2025

In test_embeddings.py, test_refresh_auth() does something to its embedding_model fixture that somehow hangs around past the end of the test, causing Connection Errors in later test files (not in its own file).

I've tried various ways to fix this; the cleanest way appears to be to put back the explicit import of the embedding_model fixture.

This fixes the problem when running tests locally, but in CI it still fails. I'm at my wits' end and plan to merge this despite the CI failures -- it's possible that the CI failures disappear once it's in main, and even if not, at least this fixes local test runs.

Tries to deal with #133.

@gvanrossum gvanrossum requested a review from robgruen December 30, 2025 16:16
@gvanrossum gvanrossum changed the title Change embedding_model fixture scope to "module" (fixes #133) Change embedding_model fixture scope to "module" Dec 30, 2025
@gvanrossum
Copy link
Collaborator Author

Dang. In CI the tests fail in exactly the same way as before. Sigh.

@gvanrossum
Copy link
Collaborator Author

That didn't help either.

@gvanrossum
Copy link
Collaborator Author

That didn't help either.

Oh, of course it didn't! The dist/ contains only things built from typegent/, and the only changes are in test/. So rolling back that ci.yml change.

I think I'm going to merge what's left -- it fixes the local tests at least, and who knows it may fix CI too once it's incorporated into main.

@gvanrossum gvanrossum changed the title Change embedding_model fixture scope to "module" Fix Connection Errors caused by subtle change to test_embeddings.py Dec 30, 2025
@gvanrossum gvanrossum merged commit 2ddf76f into main Dec 30, 2025
20 of 28 checks passed
@gvanrossum gvanrossum deleted the fixconn branch December 30, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants