-
Notifications
You must be signed in to change notification settings - Fork 41
Fix Connection Errors caused by subtle change to test_embeddings.py #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robgruen
approved these changes
Dec 30, 2025
Collaborator
Author
|
Dang. In CI the tests fail in exactly the same way as before. Sigh. |
Collaborator
Author
|
That didn't help either. |
Collaborator
Author
Oh, of course it didn't! The dist/ contains only things built from typegent/, and the only changes are in test/. So rolling back that ci.yml change. I think I'm going to merge what's left -- it fixes the local tests at least, and who knows it may fix CI too once it's incorporated into main. |
robgruen
approved these changes
Dec 30, 2025
This was referenced Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In test_embeddings.py, test_refresh_auth() does something to its embedding_model fixture that somehow hangs around past the end of the test, causing Connection Errors in later test files (not in its own file).
I've tried various ways to fix this; the cleanest way appears to be to put back the explicit import of the embedding_model fixture.
This fixes the problem when running tests locally, but in CI it still fails. I'm at my wits' end and plan to merge this despite the CI failures -- it's possible that the CI failures disappear once it's in main, and even if not, at least this fixes local test runs.
Tries to deal with #133.