Skip to content

Conversation

@sveinbjornt
Copy link
Contributor

@sveinbjornt sveinbjornt commented Jul 30, 2025

  • Explicitly supporting Python 3.14
  • Updated CI test matrix
  • Switched to ruff for linting and formatting
  • Fixed various minor linter complaints
  • Explicit package exports via all

NB: More to come, but serious changes shouldn't be lost in the linter reformatting

@sveinbjornt sveinbjornt requested a review from Copilot July 30, 2025 15:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This maintenance PR updates the project to support Python 3.14, modernizes the development toolchain by switching from Black to Ruff for linting and formatting, and includes various code quality improvements.

  • Added Python 3.14 support in project configuration and CI matrix
  • Switched from Black to Ruff for code formatting and linting
  • Fixed linting issues and improved code formatting consistency
  • Added explicit package exports via __all__ declarations

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
utils/rmh.py Updated copyright, reformatted imports, fixed linting issues, and removed unused imports
src/icegrams/trie_build.py Updated copyright dates
src/icegrams/ngrams.py Updated copyright, removed unnecessary parentheses, and cleaned up formatting
src/icegrams/init.py Updated copyright and added explicit __all__ exports
pyproject.toml Added Python 3.14 support and removed Black configuration
.github/workflows/python-package.yml Updated CI matrix to include Python 3.14 beta and additional PyPy versions
Comments suppressed due to low confidence (1)

.github/workflows/python-package.yml:15

  • The Python version '3.14.0-beta.4' may not exist or be available. Python 3.14 is not yet released and beta versions may have different naming conventions. Consider using a more general version specifier or verify the exact beta version available.
        python-version: ["3.9", "3.13", "3.14.0-beta.4", "pypy-3.9", "pypy-3.10", "pypy-3.11"]

@sveinbjornt sveinbjornt marked this pull request as ready for review July 30, 2025 16:02
@sveinbjornt sveinbjornt merged commit 92640d0 into master Jul 31, 2025
12 checks passed
@sveinbjornt sveinbjornt deleted the maint branch July 31, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants