Fix PlugConfig cache miss for empty list

[19vip]

Proposed Changes

• Fixed a race condition where the PlugConfig list cache was cleared before the database write, allowing concurrent requests to repopulate the cache with stale data.
• Updated the cache invalidation order so the database is always written before clearing the cache.
• Added missing docstrings to improve code documentation and satisfy quality checks.

Associated Issue

This issue was discovered during local backend validation while working on caching behavior. There was no existing GitHub issue at the time of discovery.

Architecture Changes

No architecture changes.

Technical Details

Previous behavior:

• Cache was deleted before serializer.save().
• A concurrent list request could read the old database state and re-cache stale values.

Fix:
serializer.save()
cache.delete(self.cache_key)

This guarantees that the cache is invalidated only after the database is consistent.

Verification

python manage.py test
curl http://127.0.0.1:8000/api/v1/plug_config/

Verified that the list endpoint populates the cache correctly and that the cache is invalidated after create, update, and delete operations.

Merge Checklist

• Fixed race condition in cache invalidation
• Local tests passing
• Docstrings added
• No breaking API changes

Summary by CodeRabbit

• Bug Fixes

  • Fixed caching logic for plug configuration queries so empty results are correctly treated as cached values, reducing unnecessary refreshes.

• New Features

  • Read-only access to plug configurations is now available without authentication (listing and retrieval); write operations remain restricted to admins.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Updated PlugConfigViewset to treat cache miss only when cached value is None, added/clarified docstrings/comments around cache invalidation timing for create/update/destroy, and adjusted permissions so list/retrieve allow unauthenticated access while write operations require admin authorization.

Changes

Cohort / File(s)	Summary
Cache condition refinement care/users/api/viewsets/plug_config.py	Changed list cache-miss check from falsy (if not cache_value) to explicit None (if cache_value is None) so cached empty lists are preserved.
Cache invalidation docs care/users/api/viewsets/plug_config.py	Added/updated docstrings and comments in perform_create, perform_update, and perform_destroy clarifying that cache deletion occurs after successful DB writes.
Permissions update care/users/api/viewsets/plug_config.py	Added/updated get_permissions to allow unauthenticated access for list and retrieve, while requiring admin permissions for create/update/destroy.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately captures the primary fix: correcting cache behavior for empty lists to prevent unnecessary database queries.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description check	✅ Passed	The PR description provides proposed changes, associated issue context, architecture details, technical explanation, verification steps, and a merge checklist, covering all template sections.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}