remove dependencies #6353
Open
remove dependencies #6353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbesson
requested changes
Dec 1, 2025
Member
sbesson
left a comment
sbesson
left a comment
There was a problem hiding this comment.
As indicated in the description, this depends on ome/omero-common#42 being included transitively into a set of releases of the omero-* server components.
In addition to the inline comments, I found a few other references to omero-common-test that should be cleaned up as part of this work
etc/omero.propertiescomponents/tools/OmeroJava/build.gradleupdate_dependencies.sh
| </dependency> | ||
| <dependency org="org.openmicroscopy" name="omero-gateway" rev="${versions.omero-gateway}"/> | ||
| <dependency org="org.openmicroscopy" name="omero-common-test" rev="${versions.omero-common-test}"/> | ||
| <!--<dependency org="org.openmicroscopy" name="omero-common-test" rev="${versions.omero-common-test}"/>--> |
Member
There was a problem hiding this comment.
Proposing to remove these lines rather than commenting them as there is no plan to reintroduce them
| <dependencies defaultconfmapping="test->*"> | ||
| <dependency org="org.openmicroscopy" name="omero-blitz" rev="${versions.omero-blitz}"/> | ||
| <dependency org="org.openmicroscopy" name="omero-common" rev="${versions.omero-common-test}"/> | ||
| <!--<dependency org="org.openmicroscopy" name="omero-common" rev="${versions.omero-common-test}"/>--> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test classes included in omero-common
see ome/omero-common#42