Fix OpenThread LuCI app and icons #28249
Open
+70
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport a pending patch to fix LuCI icons. Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
The LuCI OpenThread app is written in Lua. Add a dependency on luci-lua-runtime. Fixes: openwrt#28247 Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
3 tasks
Member
|
Could using soft links to the correct paths vs a patch be a lighter solution? |
Member
Author
|
I've submitted the patch to ot-br-posix upstream: openthread/ot-br-posix#3178 Let's see if that gets accepted. If it does, backported patch definitely has my preference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: me
Description:
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.