Make flash --check less verbose
#584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labbott
approved these changes
Nov 12, 2025
| pub fn verify( | ||
| &self, | ||
| core: &mut dyn crate::core::Core, | ||
| check_all: bool, |
Contributor
There was a problem hiding this comment.
nit: something like fail_fast is more descriptive of the actual behavior since we will technically check all the bytes if they are correct. I also hate naming things and we want to keep the logic for --verbose consistent so I'm okay with this as is.
Contributor
Author
There was a problem hiding this comment.
I'm leaning towards the slightly less descriptive name (check_all) versus needing to think about negation (fail_fast = !verbose).
|
Thanks, Matt! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default,
humility flash --checkprints every single mismatched byte. This isn't great in a manufacturing context.This PR changes the default behavior to bail on the first mismatched byte. If you want every single byte, I added a new
--verboseflag.