Skip to content

Conversation

@sgaist
Copy link
Contributor

@sgaist sgaist commented Dec 26, 2025

Summary

Harmonize the tools helper scripts so that pack installation works in all cases.

Currently, running integration tests does not work on macOS as pack fails to download.

The builder and stack tools helper scripts already had the fix to install pack on macOS.

This patch harmonizes that.

Use Cases

Run integration tests on macOS while developing buildpacks

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

The builder and stack scripts already had the
fix to install pack on macOS.
@sgaist sgaist requested review from a team as code owners December 26, 2025 09:13
Copy link
Member

@pacostas pacostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please explain how this argument fixes your error because I cant see any scenario for macos on the util:tools::os funcions for the implementation

function util::tools::os() {
case "$(uname)" in
"Darwin")
echo "${1:-darwin}"
;;
"Linux")
echo "linux"
;;
*)
util::print::error "Unknown OS \"$(uname)\""
exit 1
esac
}

and for the language family buildpacks

function util::tools::os() {
case "$(uname)" in
"Darwin")
echo "${1:-darwin}"
;;
"Linux")
echo "linux"
;;
*)
util::print::error "Unknown OS \"$(uname)\""
exit 1
esac
}

@pacostas
Copy link
Member

Can you please explain how this argument fixes your error because I cant see any scenario for macos on the util:tools::os funcions for the implementation

function util::tools::os() {
case "$(uname)" in
"Darwin")
echo "${1:-darwin}"
;;
"Linux")
echo "linux"
;;
*)
util::print::error "Unknown OS \"$(uname)\""
exit 1
esac
}

and for the language family buildpacks

function util::tools::os() {
case "$(uname)" in
"Darwin")
echo "${1:-darwin}"
;;
"Linux")
echo "linux"
;;
*)
util::print::error "Unknown OS \"$(uname)\""
exit 1
esac
}

Actaully now I see, you are right. Im approving it right away

@pacostas pacostas merged commit 0059bf3 into paketo-buildpacks:main Dec 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants