fix(ldap-select): Filter ldap dropdown entries with search text #16
+59
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
This pull request improves how the
searchTextparameter is handled in the LDAP dropdown functionality and adds corresponding tests to ensure correct behavior. The main changes involve reading the correct request parameter and verifying expected outcomes through new test cases.Improvements to request parameter handling:
LdapDropdownControllernow correctly reads thesearchTextparameter from the request, defaulting to an empty string if not provided.Enhancements to test coverage:
testSearchTextParameterto verify that providing asearchTextvalue returns the expected filtered results in the response.testEmptySearchTextParameterto ensure that an emptysearchTextreturns the expected number of results.