Skip to content

Conversation

@ccailly
Copy link
Contributor

@ccailly ccailly commented Dec 31, 2025

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.

Description

This pull request improves how the searchText parameter is handled in the LDAP dropdown functionality and adds corresponding tests to ensure correct behavior. The main changes involve reading the correct request parameter and verifying expected outcomes through new test cases.

Improvements to request parameter handling:

  • The LdapDropdownController now correctly reads the searchText parameter from the request, defaulting to an empty string if not provided.

Enhancements to test coverage:

  • Added testSearchTextParameter to verify that providing a searchText value returns the expected filtered results in the response.
  • Added testEmptySearchTextParameter to ensure that an empty searchText returns the expected number of results.

@ccailly ccailly self-assigned this Dec 31, 2025
@ccailly ccailly added the bug Something isn't working label Dec 31, 2025
@AdrienClairembault AdrienClairembault merged commit 66a8887 into main Jan 2, 2026
3 checks passed
@AdrienClairembault AdrienClairembault deleted the fix/ldap-select-dropdown-search branch January 2, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dynamic filtering in LDAP question

3 participants