Changes for new TCG trace plugin #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This becomes necessary because the trace now only has registers from GDB. They might mismatch how they are modelled in Rizin.
…t here everything is v9 style.
The instance of RzReg of the RizinEmulator never set the correct endianness
This comment was marked as resolved.
This comment was marked as resolved.
notxvilka
approved these changes
Aug 14, 2025
notxvilka
left a comment
notxvilka
left a comment
There was a problem hiding this comment.
@thestr4ng3r take a look too, please
wargio
reviewed
Aug 15, 2025
wargio
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR to BinaryAnalysisPlatform/qemu#41
and BinaryAnalysisPlatform/bap-frames#28
Bundles all changes if any are necessary.
todo