-
-
Notifications
You must be signed in to change notification settings - Fork 13
Blog: Adding Mark API in Rizin #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rot127
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggestions.
I would recommend to put the text once into a proofreader (e.g.: https://translate.kagi.com/proofread). Just to check if there are obvious improvements.
|
|
||
| #### **Iteration** | ||
| - `rz_mark_foreach()` iterate through all marks | ||
| - `rz_mark_foreach_glob()` iterate through marks filtered by glob patterns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ui, we missed this naming. glob refers to path name expansions. Not necessarily to regex patterns. @notxvilka @wargio Should we rename this before we release the blog post?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PremadeS As discussed in mattermost, please be so kind and rename glob -> regex. Also open a PR in the code please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rot127 Done
Rot127
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Only the glob thingy is left
|
Should be merged together with rizinorg/cutter.re#59 and then modified to cross-link the posts. |
Added a blog:
RSoC 2025 - Adding Mark API