Skip to content

Conversation

@PremadeS
Copy link
Contributor

@PremadeS PremadeS commented Oct 4, 2025

Added a blog:
RSoC 2025 - Adding Mark API

Copy link
Member

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions.
I would recommend to put the text once into a proofreader (e.g.: https://translate.kagi.com/proofread). Just to check if there are obvious improvements.


#### **Iteration**
- `rz_mark_foreach()` iterate through all marks
- `rz_mark_foreach_glob()` iterate through marks filtered by glob patterns
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ui, we missed this naming. glob refers to path name expansions. Not necessarily to regex patterns. @notxvilka @wargio Should we rename this before we release the blog post?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PremadeS As discussed in mattermost, please be so kind and rename glob -> regex. Also open a PR in the code please.

Copy link
Contributor Author

@PremadeS PremadeS Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rot127 Done

@PremadeS PremadeS requested a review from Rot127 October 5, 2025 13:56
Copy link
Member

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Only the glob thingy is left

@notxvilka
Copy link
Contributor

Should be merged together with rizinorg/cutter.re#59 and then modified to cross-link the posts.

@notxvilka notxvilka merged commit 2e4fe26 into rizinorg:main Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants