[PR]: Add get_similar_icons() and tests (#15)
#16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadenbuie
reviewed
Mar 27, 2025
Member
gadenbuie
left a comment
gadenbuie
left a comment
There was a problem hiding this comment.
This is a nice feature and I think it will certainly be helpful to everyone, thanks for contributing!
Can you please do a quick pass of get_similar_icons() to de-LLM-ify the code? (Remove unnecessary comments and roxygen2 tags, abstract some repeated code, etc.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for issue #15
get_similar_icons()bs_icon()