Skip to content

Conversation

@samchon
Copy link
Owner

@samchon samchon commented Jul 15, 2025

This pull request introduces a version update to the tgrid package and enhances the WorkerConnector class by improving parameter naming and adding support for specifying the working directory and environment variables for worker processes. Below are the key changes:

Version Update:

  • package.json: Updated the package version from 1.1.0 to 1.2.0.

Enhancements to WorkerConnector:

  • src/protocols/workers/WorkerConnector.ts:
    • Renamed the timeout parameter to options for better clarity in both the compile and connect methods. [1] [2]
    • Added new options (cwd for current working directory and env for environment variables) in the WorkerConnector namespace to allow more control over worker server initialization.

Process Worker Support:

@samchon samchon requested a review from Copilot July 15, 2025 08:50
@samchon samchon self-assigned this Jul 15, 2025
@samchon samchon added the enhancement New feature or request label Jul 15, 2025
@socket-security
Copy link

socket-security bot commented Jul 15, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednext@​14.2.48325949870
Addednextra@​2.13.4821007097100
Addednextra-theme-docs@​2.13.4981007297100
Addednext-sitemap@​4.2.310010010077100
Updatedrimraf@​2.4.5 ⏵ 5.0.7100100100 +2077 +1100
Addedreact@​18.3.11001008397100
Addedtypescript@​5.5.210010089100100
Addedreact-dom@​18.3.11001009197100
Addedtypedoc@​0.26.21001009896100

View full report

@socket-security
Copy link

socket-security bot commented Jul 15, 2025

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert (click for details)
Warn Critical
next@14.2.4 has a Critical CVE.

CVE: GHSA-f82v-jwr5-mffw Authorization Bypass in Next.js Middleware (CRITICAL)

Affected versions: >= 13.0.0 < 13.5.9; >= 14.0.0 < 14.2.25; >= 15.0.0 < 15.2.3; >= 11.1.4 < 12.3.5

Patched version: 14.2.25

From: website/package-lock.jsonnpm/next@14.2.4

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/next@14.2.4. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the tgrid package to version 1.2.0, renames the timeout parameter to options for clarity, and introduces cwd and env options to control worker process environments.

  • Bump package version from 1.1.0 to 1.2.0
  • Rename timeout to options in WorkerConnector methods
  • Add cwd and env support in WorkerConnector and forward them in ProcessWorker

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
package.json Bumped version from 1.1.0 to 1.2.0
src/protocols/workers/WorkerConnector.ts Renamed timeout to options and added required cwd/env
src/protocols/workers/internal/processes/ProcessWorker.ts Forward cwd and env into fork options
Comments suppressed due to low confidence (3)

src/protocols/workers/WorkerConnector.ts:358

  • The new cwd field is marked as required. Consider making it optional (cwd?: string) to avoid breaking existing callers who do not provide this option.
    cwd: string;

src/protocols/workers/WorkerConnector.ts:363

  • The env option is required and replaces the entire child process environment. Consider making it optional (env?: Record<string, string>) and merging it with process.env in the fork call to preserve inherited variables.
    env: Record<string, string>;

src/protocols/workers/internal/processes/ProcessWorker.ts:23

  • Add tests to verify that the cwd option correctly sets the working directory of the forked process, ensuring the new behavior works as expected in various environments.
        cwd: options?.cwd,

samchon and others added 2 commits July 15, 2025 17:51
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@samchon samchon merged commit 1b0710e into master Jul 15, 2025
7 checks passed
@samchon samchon deleted the feat/cwd branch July 15, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants