Skip to content

Conversation

@vi
Copy link
Contributor

@vi vi commented Jan 3, 2025

Resolves #265.

@taiki-e
Copy link
Owner

taiki-e commented Jan 25, 2025

Thanks for the PR! I'm positive on adding this feature. However:

  • CI is failing, so please fix that.
    • It should be able to be fixed by running cargo fmt and adding the words listed here to .github/.cspell/project-dictionary.txt.
  • Usually, I tend to choose fastrand over rand as a library for randomization unless rand is necessary for security reasons.

@taiki-e taiki-e added the A-features Area: features (--feature-powerset, --each-feature, etc.) label Jan 25, 2025
@vi
Copy link
Contributor Author

vi commented Jan 25, 2025

Is it a good idea to also add (in this PR) a pagination options (like --powerset-start-from=3000 --powerset-num-tests=1000) for splitting big scans over multiple invocations?

@taiki-e
Copy link
Owner

taiki-e commented Jan 25, 2025

As for the addition of other options, it would be easier to review if they were separated into separate PRs.

@vi
Copy link
Contributor Author

vi commented Jan 25, 2025

As for the addition of other options, it would be easier to review if they were separated into separate PRs.

Implemented as a continuation PR: vi#1

Note that for some reason it includes empty feature set case in each run.

@elichai
Copy link

elichai commented Jun 4, 2025

Any updates on this? can I help somehow? This will help me a lot, currently I have ~80 jobs, where only ~15 of them have meaningful tests, I partition them, but the biggest tests all fall on the same partition :(

@taiki-e
Copy link
Owner

taiki-e commented Jun 4, 2025

@elichai As discussed in vi#1, what is needed here is for someone to take over #255 and complete it.

@elichai
Copy link

elichai commented Jun 4, 2025

@elichai As discussed in vi#1, what is needed here is for someone to take over #255 and complete it.

Thank you!
Commented there to understand better what's missing. (if you don't have the capacity and/or my comments are not helpful feel free to ignore me :) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-features Area: features (--feature-powerset, --each-feature, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Randomizing order of trials in --feature-powerset

3 participants