Fix 'Delete All Predictions...' deleting user instances in multi-video projects #2511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jects The bug was caused by video.matches_content() returning True for ALL videos with the same dimensions (shape and backend type). This caused remove_frames() to incorrectly match and remove frames from all videos instead of just the target video. Added videos_match() helper that uses object identity instead of matches_content() for internal operations where we're comparing videos from the same Labels object. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2511 +/- ##
===========================================
- Coverage 56.44% 56.44% -0.01%
===========================================
Files 71 71
Lines 14302 14304 +2
===========================================
+ Hits 8073 8074 +1
- Misses 6229 6230 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Updated videos_match() to use matches_content() AND matches_path(strict=True) instead of object identity alone. This approach: 1. Preserves content comparison (shape and backend type) 2. Distinguishes different video files with same dimensions (e.g., 1-frame .tifs) 3. Works after deserialization when videos have same path but different object IDs The original fix used object identity (`is`) which would fail to match the same video after deserialization. The new approach uses sleap-io's matches_path() method which correctly handles both single video files and ImageVideo backends (list of frame paths). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
video.matches_content()returns True for ALL videos with the same dimensions (shape and backend type), causingremove_frames()to remove frames from all videos instead of just the targetremove_frames()on videos w/ ImageVideo backend and 1 frame (.tif): frame to remove is idx 0 ->remove_frames()checks video shape & backend type + labeled frame idx (0 for .tif ImageVideos) -> calllabels_pop()matches_path()functionTest plan
🤖 Generated with Claude Code