Skip to content

Remove beforeEach and afterEach test methods #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
MoonBow-1 wants to merge 106 commits into
base: master
Choose a base branch
from
Draft

Remove beforeEach and afterEach test methods #44

MoonBow-1 wants to merge 106 commits into from

Conversation

@MoonBow-1
Copy link
Contributor

@MoonBow-1 MoonBow-1 commented Aug 11, 2025 •
edited
Loading

Should be merged only after Pr #15 is closed!
Closes #31

  • Removes the annotated methods from test files
  • Converts Spring Boot tests to normal unit tests

MoonBow-1 added 30 commits May 6, 2025 16:25
@MoonBow-1
Rename HttpEventData.java to DefaultHttpEventData.java
8654c99
@MoonBow-1
Create decorator for DefaultHttpEventData
c97c2d0 
- Time to migrate the time related tests from ServiceAndEventManagerIT to TimestampedHttpEventDataTest
@MoonBow-1
Generate tests for TimestampedHttpEventData
240b08e 
- 4 failing assertions found in this commit
@MoonBow-1
Remove PowerMock from pom.xml
273787a
@MoonBow-1
Check for time length when asking for timeSource and timeParsed
0a8d2bf
@MoonBow-1
Remove unused field ackID from DefaultHttpEventData
2727774
@MoonBow-1
Fix variable initialization order when parsing time as Double
cc5737c
@MoonBow-1
Update Copyright to year 2025
d24940e
@MoonBow-1
Add RELP server from jla_01 for usage in tests
442eb1e
@MoonBow-1
Fix ConfigurationIT test
d3be228
@MoonBow-1
Make HECServiceImpl.sendEvents synchronized
2464a01 
- Fixes tests
- Performance impact
@MoonBow-1
Change headers to say when copyright begins
b4e76ca
@MoonBow-1
Update Apache RAT pattern for license
33e38b3
@MoonBow-1
Revert all cosmetic changes to formatting
9ece989
@MoonBow-1
Reformat pom.xml to have important info at the top
09e5a7e
@MoonBow-1
Remove commented out old tests
e1a3f65
@MoonBow-1
Use assertDoesNotThrow instead of try-catch for test
7cde200
@MoonBow-1
Add assertions for count of assertions in loops
c3b8d26
@MoonBow-1
Update JavaDoc about EpochTimeString.asEpochMillis
eacbe5e
@MoonBow-1
Update assertion failure messages to indicate reason, not the goal
8490552
@MoonBow-1
Use literal ints for expected loop iterations in tests
0eb6ffe
@MoonBow-1
Restore missing synchronized keyword removed in 063bc3a
ce43e84
@MoonBow-1
Specify compiler plugin to use the '-parameters' arg
fa82392 
- Otherwise does compile, but doesn't start properly
@MoonBow-1
Revert license modified by accident in SyslogMessageSender
03b8e3b 
- License gotten from fa28602
@MoonBow-1
Add Spotless beck to pom.xml after rebase
3256342
@MoonBow-1
Exclude eclipse-java-formatter.xml from Apache Rat
36a7371
@MoonBow-1
Fix ServiceAndEventManagerIT test where an ackID is not supposed to b…
01fd702 
…e returned
@MoonBow-1
Remove commented out code from ServiceAndEventManagerIT
ab35e33
@MoonBow-1
Update Apache Rat license header to correct year
4d8069d
@MoonBow-1
Remove dashes from the license header in log4j2.xml
11148e0
MoonBow-1 added 29 commits June 24, 2025 09:18
@MoonBow-1
Rename HttpEventData to HECRecord
03fa4f3
@MoonBow-1
Implement HECTime classes
a73376e 
- Old Time classes have been deleted
- Tests are missing and broken at the moment
@MoonBow-1
Rename ConverterTests.java to EventDataToSyslogMessageTest.java
6a08482
@MoonBow-1
Apply quick fixes to for-loops and variable assignments in EventDataT…
774c345 
…oSyslogMessageTest
@MoonBow-1
Cleanup variables in EventDataToSyslogMessageTest
8639e84
@MoonBow-1
Method overload HECRecord.toSyslogMessage so it can accept a defaultV…
efecedd 
…alue

- Allows for tests to declare an expected value
- Tested by running the test file 1000 times
@MoonBow-1
Implement equals and hashCode tio HeaderInfo
f358639
@MoonBow-1
Use a different way of checking HECBatchTest.asHttpEventDataListTest
ac241d8
@MoonBow-1
Remove unused method found in JsonEvent
cd83398
@MoonBow-1
Remove unused objects
f7a7955
@MoonBow-1
Implement parsed() method for HECTimeImplWithFallback and add tests f…
e072430 
…or that
@MoonBow-1
Implement source() method for HECTimeImplWithFallback and add tests f…
1e35ccb 
…or that
@MoonBow-1
Add equals test for HECTimeImplWithFallback
f03cf67
@MoonBow-1
Implement unit tests for HECTimeImplWithFallback.instant()
7142853
@MoonBow-1
Remove assertions and thread lifetime from Jmeter test
97b4428 
- Causes problems if the test is not run in 30 seconds
@MoonBow-1
Add JavaDoc to describe the Event interface
587d182
@MoonBow-1
Move test class to correct package
362b566
@MoonBow-1
Rename Event to EventMessage for more clarity
b5f0c4c
@MoonBow-1
Rename variables to new object names
cd884eb 
- Some vars were not renamed when refactoring objects, so fix the HttpEvent... references
@MoonBow-1
Remove "shared" ObjectMapper in HECTimeImplTest
f45d39b
@MoonBow-1
Convert AcknowledgementsIT from SpringBootTest to JUnit test
e72fe6a 
- Allows Configuration to be configurable via ctor
- Allows Configuration to be a parameter to Acknowledgements via ctor
@MoonBow-1
Convert ConfigurationIT from SpringBootTest to JUnit test
ebdcdb0
@MoonBow-1
Convert SendMultipleEventsIT from SpringBootTest to JUnit test
af53728 
- Allows HECServiceImpl to specify fields with a new ctor
@MoonBow-1
Convert SendSingleEventIT from SpringBootTest to JUnit test
a16de7b
@MoonBow-1
Convert ServiceAndHECBatchIT from SpringBootTest to JUnit test
aec0858
@MoonBow-1
Remove static variables from HECBatchTest
6cc5db1
@MoonBow-1
Remove static variables and BeforeEach from SessionManagerTests
eafa590
@MoonBow-1
Remove shared variable from TokenManagerTest
a109c4a 
- TokenManagerTests renamed to TokenManagerTest
@MoonBow-1
Remove unused import in ServiceAndHECBatchIT
f2219c1
@MoonBow-1 MoonBow-1 self-assigned this Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@MoonBow-1 MoonBow-1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate possibility of removing JUnit @BeforeEach, @AfterEach etc. annotations

1 participant

@MoonBow-1