Cfe04 transform endpoints refactored separately #171
Conversation
Nefarious46
force-pushed
the
Cfe04TransformEndpointRefactor
branch
from
7cdbc64 to
569eaa9
Compare
| String state = error + "-" + ((SQLException) cause).getSQLState(); | ||
| JSONObject jsonErr = new JSONObject(); | ||
| jsonErr.put("id", newCfe04Transform.getId()); | ||
| if (state.equals("1452-23000")) { |
There was a problem hiding this comment.
use && instead of string concat
| public ResponseEntity<String> addNewCfe04Transform(@RequestBody Cfe04Transform newCfe04Transform) { | ||
| @ApiResponse(responseCode = "404", description = "Cfe04 does not exist", | ||
| content = @Content), | ||
| @ApiResponse(responseCode = "500", description = "Internal server error, contact admin", content = @Content)}) |
There was a problem hiding this comment.
500 swapped to 400
| @ApiResponse(responseCode = "200", description = "cfe_04 transforms retrieved", | ||
| content = {@Content(mediaType = "application/json", | ||
| schema = @Schema(implementation = Cfe04Transform.class))}), | ||
| @ApiResponse(responseCode = "500", description = "Internal server error, contact admin", content = @Content) |
There was a problem hiding this comment.
500 swapped to 400
| @ApiResponse(responseCode = "500", description = "Internal server error, contact admin", content = @Content) | ||
| }) | ||
| public ResponseEntity<String> deleteCfe04Transform(@PathVariable("id") Integer id) { | ||
| @ApiResponse(responseCode = "500", description = "Internal server error, contact admin", content = @Content)}) |
There was a problem hiding this comment.
500 swapped to 400
|
|
||
| // Assertions | ||
| assertEquals(expected, actual); | ||
| assertThat( |
| @Order(3) | ||
| @Order(4) | ||
| @Description("Tests that ALL cfe_04 transforms can be fetched") | ||
| public void testGetALLCfe04Transforms() { |
There was a problem hiding this comment.
test case for empty list added
| @Order(4) | ||
| @Description("Tests that ALL cfe_04 transforms can be fetched") | ||
| public void testGetALLCfe04Transforms() { | ||
|
|
There was a problem hiding this comment.
test case for trying to get invalid id transform?
There was a problem hiding this comment.
Procedure did not check if id is valid which returns empty list instead. Will correct so that error is thrown if there is no cfe_04 to fetch from.
There was a problem hiding this comment.
Now checks if transforms record does not exists in cfe_04_transforms table with given cfe_04 id. If record is missing then error is thrown. This is tested testGetCfe04TransformsInvalidId test method.
Nefarious46
force-pushed
the
Cfe04TransformEndpointRefactor
branch
from
569eaa9 to
8019ad7
Compare
3 participants
More info on PR #155