Skip to content

Conversation

@Nefarious46
Copy link
Contributor

Description

Implemented Host Meta request and response objects since "hostname" is required in various configuration files.

  • HostMeta interface for fetching information regarding HostMeta
  • HostMetaRequest interface for requesting HostMeta details from external datasource and for faking later
  • HostMetaResponse implementation of HostMeta interface
  • HostMetaRequestImpl implementation of the request interface

Checklists

Testing

General

  • I have checked that my test files and functions have meaningful names.
  • I have checked that each test tests only a single behavior.
  • I have done happy tests.
  • I have tested only my own code.
  • I have tested at least all public methods.

Assertions

  • I have checked that my tests use assertions and not runtime overhead.
  • I have checked that my tests end in assertions.
  • I have checked that there is no comparison statements in assertions.
  • I have checked that assertions are in tests and not in helper functions.
  • I have checked that assertions for iterables are outside of for loops and both sides of the iteration blocks.
  • I have checked that assertions are not tested inside consumers.

Testing Data

  • I have tested algorithms and anything else with the possibility of unbound growth.
  • I have checked that all testing data is local and fully replaceable or reproducible or both.
  • I have checked that all test files are standalone.
  • I have checked that all test-specific fake objects and classes are in the test directory.
  • I have checked that my tests do not contain anything related to customers, infrastructure or users.
  • I have checked that my tests do not contain non-generic information.
  • I have checked that my tests do not do external requests and are not privately or publicly routable.

Statements

  • I have checked that my tests do not use throws for exceptions.
  • I have checked that my tests do not use try-catch statements.
  • I have checked that my tests do not use if-else statements.

Java

  • I have checked that my tests for Java uses JUnit library.
  • I have checked that my tests for Java uses JUnit utilities for parameters.

Other

  • I have only tested public behavior and not private implementation details.
  • I have checked that my tests are not (partially) commented out.
  • I have checked that hand-crafted variables in assertions are used accordingly.
  • I have tested Object Equality.
  • I have checked that I do not have any manual tests or I have a valid reason for them and I have explained it in the PR description.

Code Quality

  • I have checked that my code follows metrics set in Procedure: Class Metrics.
  • I have checked that my code follows metrics set in Procedure: Method Metrics.
  • I have checked that my code follows metrics set in Procedure: Object Quality.
  • I have checked that my code does not have any NULL values.
  • I have checked my code does not contain FIXME or TODO comments.

@Nefarious46 Nefarious46 requested a review from MoonBow-1 August 5, 2025 14:20
@Nefarious46 Nefarious46 self-assigned this Aug 5, 2025
@Nefarious46 Nefarious46 added the enhancement New feature or request label Aug 5, 2025
Copy link

@MoonBow-1 MoonBow-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some issues found in the tests

@Nefarious46 Nefarious46 requested a review from MoonBow-1 August 6, 2025 08:03
Copy link

@MoonBow-1 MoonBow-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Nefarious46 Nefarious46 linked an issue Aug 6, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Host Meta implementation

2 participants