Skip to content

Conversation

@elliVM
Copy link

@elliVM elliVM commented Dec 17, 2025

Description

Add spotless plugin and apply.

  • Formats Java code
  • Updates licenses on .java and .g4 files
  • Does not update licenses on .txt or .xml files
  • Apache Rat plugin set to approve old and new licenses

Notes

  • .txt and .xml files both have different types of comment styles and would there require their own license files, decided not to add.

@elliVM elliVM self-assigned this Dec 17, 2025
@elliVM elliVM linked an issue Dec 17, 2025 that may be closed by this pull request
@elliVM elliVM requested a review from Tiihott December 17, 2025 09:02
Copy link

@Tiihott Tiihott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass and spotless check/apply work as expected. But the Spotless configuration is missing the <toggleOffOn></toggleOffOn> which should be added.

@elliVM elliVM requested a review from Tiihott December 18, 2025 07:19
Copy link

@Tiihott Tiihott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elliVM elliVM requested a review from kortemik December 18, 2025 07:57
@elliVM elliVM added the review label Dec 18, 2025
@kortemik kortemik requested review from StrongestNumber9 and removed request for kortemik December 18, 2025 11:24
@kortemik
Copy link
Member

@StrongestNumber9 please verify and approve if ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add spotless

3 participants