-
Notifications
You must be signed in to change notification settings - Fork 9
Refactor planner Kafka Query #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
elliVM
wants to merge
8
commits into
teragrep:main
Choose a base branch
from
elliVM:kafka-query-impl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kortemik
reviewed
Apr 4, 2025
…estcontainers tests for kafka behavior
elliVM
commented
Apr 9, 2025
src/main/java/com/teragrep/pth_06/planner/RegexMatchingKafkaTopics.java
Outdated
Show resolved
Hide resolved
elliVM
commented
Apr 9, 2025
elliVM
commented
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Goals is to replace
poll(timeout)method completely since it was causing stalls when topic had no records or was unauthorized. Old way subscribed using a pattern and then usedpoll()to get offsets from the meta data.Now we use the
listTopics()method to list all topics the user has access to and then filter them using a regex pattern from the query. After that we can use the resulting topics to get offsets for all the partitions.Class responsibilities
CombinedTopicPartitionscombined partitions of a list of topicsKafkaQueryImplimplementsKafkaQueryto get beginning and end offsets of all topics partitions for a queryKafkaSubscriptionPatternFromQueryparses a regex pattern from incoming query XMLRegexMatchingKafkaTopicsfilters topics using a regex patternSetOnceallows for delayed setting of a immutable state, used to store a snapshot of Kafka topics fetched from serverTopicPartitionsprovides partitions of a topicTopicsFromKafkalists all topics in Kafka available for user