Make SSH integration tests easier to debug #1046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adombeck
force-pushed
the
improve-ssh-tests
branch
from
a9453fd to
cda8f9b
Compare
adombeck
force-pushed
the
improve-ssh-tests
branch
11 times, most recently
from
7762549 to
28f1faa
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1046 +/- ##
==========================================
- Coverage 87.78% 86.77% -1.02%
==========================================
Files 89 90 +1
Lines 6150 6222 +72
Branches 111 111
==========================================
Hits 5399 5399
- Misses 695 750 +55
- Partials 56 73 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adombeck
force-pushed
the
improve-ssh-tests
branch
16 times, most recently
from
f1d6e86 to
a0718d1
Compare
I've seen this test time out in the CI.
So that we're able to use them from other packages than the pam/integration-tests.
Writing both stdout and stderr to the same file causes a data race. Lets use our SyncBuffer instead.
It failed with that error in CI:
ssh_test.go:491:
Error Trace: /home/runner/work/authd/authd/pam/integration-tests/ssh_test.go:795
/home/runner/work/authd/authd/pam/integration-tests/ssh_test.go:659
/home/runner/work/authd/authd/pam/integration-tests/ssh_test.go:491
/home/runner/work/authd/authd/internal/testutils/testrun.go:83
Error: Received unexpected error:
dial tcp :35523: connect: connection reset by peer
Test: TestSSHAuthenticate/Authenticate_user_switching_auth_mode
The tool's spelling is VHS, not vhs, so let's use that.
We now require Go >= 1.25 so we can drop our workaround for older versions.
As suggested by reviewer.
As Marco pointed out, in Meson terminology a shared module is a module that's suitable for dlopen() but not intended as a link target for other build targets. That matches what we're building here, so lets use "shared module" instead of "shared library".
require.Contains prints the full `outStr` in the error message without newlines (it prints them as '\n') which only repeats output that is already there in a very unreadable way.
As requested by reviewer. We didn't encounter a case yet where we needed it.
adombeck
force-pushed
the
improve-ssh-tests
branch
from
4ab329e to
44d38b9
Compare
3v1n0
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for improved debuggability, test execution time, and maintainability, including:
UDENG-8137